public inbox for ecos-bugs@sourceware.org help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org To: unassigned@bugs.ecos.sourceware.org Subject: [Bug 1001635] New: wrong results from Cyg_StdioStream::read Date: Fri, 27 Jul 2012 10:37:00 -0000 [thread overview] Message-ID: <bug-1001635-777@http.bugs.ecos.sourceware.org/> (raw) Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001635 Summary: wrong results from Cyg_StdioStream::read Product: eCos Version: CVS Platform: All OS/Version: All Status: UNCONFIRMED Severity: normal Priority: normal Component: C library AssignedTo: unassigned@bugs.ecos.sourceware.org ReportedBy: bernd.edlinger@hotmail.de CC: ecos-bugs@ecos.sourceware.org Class: Advice Request Created an attachment (id=1849) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1849) proposed patch to fix this defect. there are several different code paths which can lead to wrong results in the function Cyg_StdioStream::read(). Please have a look at the following file: "ecos/packages/language/c/libc/stdio/current/src/common/stream.cxx". Suppose we are in unbuffered mode. There may be an unread character in the "ungetc" buffer. And there may be an unread character in the "readbuf_char" buffer. Then the code may go thru the if statement in line 340, and later thru the if statement in line 382. BUG: in line 384: *bytes_read = 1; is wrong, we have 2 bytes read. Now suppose we are in unbuffered mode again. There may be an unread character in the "ungetc" buffer. And the buffer_length may be 3 or higher. Then the code may go thru the if statement in line 340, and later thru the if statement in line 394. BUG: user_buffer was already incremented in line 341. So the returned data will contain an uninitialized byte in the middle. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
next reply other threads:[~2012-07-27 10:37 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-27 10:37 bugzilla-daemon [this message] 2012-07-27 10:37 bugzilla-daemon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-1001635-777@http.bugs.ecos.sourceware.org/ \ --to=bugzilla-daemon@bugs.ecos.sourceware.org \ --cc=unassigned@bugs.ecos.sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).