From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7702 invoked by alias); 1 Aug 2012 09:11:34 -0000 Received: (qmail 7666 invoked by uid 22791); 1 Aug 2012 09:11:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Aug 2012 09:11:18 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 4C26C2F78005 for ; Wed, 1 Aug 2012 10:11:17 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TCk3eiMIov60; Wed, 1 Aug 2012 10:11:12 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-bugs@ecos.sourceware.org Subject: [Bug 1001641] New: Erase function in flashiodev.c and flashiodevlegacy.c handle "err_address" differently X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Flash X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: bernd.edlinger@hotmail.de X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Wed, 01 Aug 2012 09:11:00 -0000 Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg01104.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001641 Summary: Erase function in flashiodev.c and flashiodevlegacy.c handle "err_address" differently Product: eCos Version: CVS Platform: All OS/Version: All Status: UNCONFIRMED Severity: enhancement Priority: low Component: Flash AssignedTo: unassigned@bugs.ecos.sourceware.org ReportedBy: bernd.edlinger@hotmail.de CC: ecos-bugs@ecos.sourceware.org Class: Advice Request Created an attachment (id=1854) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1854) proposed patch to fix this defect. In the function flashiodev_get_config(..,CYG_IO_GET_CONFIG_FLASH_ERASE,..) the meaning of e->err_address is different in flashiodev.c and in flashiodevlegacy.c: Either the address where the error was encountered, or an address where the result should be stored. IMHO, the implementation in flashiodev.c makes more sense, and the flashiodevlegacy.c should be changed accordingly. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.