public inbox for ecos-bugs@sourceware.org help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org To: unassigned@bugs.ecos.sourceware.org Subject: [Bug 1001656] FreeBSD: add AF_PACKET socket familiy Date: Tue, 21 Jan 2014 16:46:00 -0000 [thread overview] Message-ID: <bug-1001656-777-zMqAHl6jCz@http.bugs.ecos.sourceware.org/> (raw) In-Reply-To: <bug-1001656-777@http.bugs.ecos.sourceware.org/> Please do not reply to this email, use the link below. http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001656 Grant Edwards <grant.b.edwards@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grant.b.edwards@gmail.com --- Comment #15 from Grant Edwards <grant.b.edwards@gmail.com> --- First, thanks for taking the time to find/fix all these bugs. I'd like to start working on getting these committed. After a preliminary look through the patches I have a few suggestions on how to more quickly get things committed. The patches contain hundreds diffs where nothing has changed but whitespace (usually at the end of the line): diff -Nur ecos-cvs-120723/packages/io/eth/current/src/net/eth_drv.c ecos/packages/io/eth/current/src/net/eth_drv.c --- ecos-cvs-120723/packages/io/eth/current/src/net/eth_drv.c 2009-01-29 18:49:45.000000000 +0100 +++ ecos/packages/io/eth/current/src/net/eth_drv.c 2012-08-02 14:30:54.000000000 +0200 @@ -146,8 +146,8 @@ static int simulate_fail( struct eth_drv_sc *sc, int which ) { - struct simulated_failure_state *s; - + struct simulated_failure_state *s; + for ( s = &simulated_failure_states[0]; s < &simulated_failure_states[2]; s++ ) { if ( 0 == s->sc ) { Having to wade through the non-changes visually searching for the real changes makes it that much more difficult to review. Applying the patches and then using a diff tool like meld that can ignore whitespace changes is one work-around, but being able to use Bugzilla's built-in (though somewhat less intelligent) tools makes life easier for anybody reviewing the code. I realize that deleting trailing whitespace is a side-effect of using certain editors and probably wasn't done intentionally. Cleaning up whitespace from ends of lines is fine, but it it should probably be in a separate patch that does nothing but whitespace cleanup. Splitting the changes up into smaller patches would also make it much easier. A separate patch for the AF_PACKET support and for each of the 10 bugs you listed would be ideal. That way somebody reviewing the code doesn't have to try to figure out which bug a particular change is addressing. It also means that the work of reviewing and committing the changes can be divided up among multiple maintainers. Next is the question of copyright assignment. I'm not sure where the threshold is for "trivial" changes above which a copyright assignment is needed, and hopefully some other maintainers to comment on that. There's probably a good chance that for a contribution this large a copyright assignment will be needed. -- Grant -- You are receiving this mail because: You are the assignee for the bug.
next prev parent reply other threads:[~2014-01-21 16:46 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-17 13:51 [Bug 1001656] New: " bugzilla-daemon 2012-08-17 13:54 ` [Bug 1001656] " bugzilla-daemon 2012-08-17 15:12 ` bugzilla-daemon 2012-09-14 14:08 ` bugzilla-daemon 2013-06-25 17:11 ` bugzilla-daemon 2013-07-15 12:01 ` bugzilla-daemon 2013-07-23 18:48 ` bugzilla-daemon 2013-11-26 10:21 ` bugzilla-daemon 2013-12-01 23:55 ` bugzilla-daemon 2013-12-06 15:38 ` bugzilla-daemon 2013-12-08 23:55 ` bugzilla-daemon 2013-12-15 2:00 ` bugzilla-daemon 2014-01-21 16:46 ` bugzilla-daemon [this message] 2014-01-22 7:46 ` bugzilla-daemon 2014-01-31 10:39 ` bugzilla-daemon 2014-01-31 10:41 ` bugzilla-daemon 2014-01-31 10:43 ` bugzilla-daemon 2014-01-31 10:44 ` bugzilla-daemon 2014-01-31 10:51 ` bugzilla-daemon 2015-06-10 8:48 ` bugzilla-daemon 2015-06-10 8:53 ` bugzilla-daemon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-1001656-777-zMqAHl6jCz@http.bugs.ecos.sourceware.org/ \ --to=bugzilla-daemon@bugs.ecos.sourceware.org \ --cc=unassigned@bugs.ecos.sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).