From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15793 invoked by alias); 3 Sep 2012 14:28:43 -0000 Received: (qmail 15782 invoked by uid 22791); 3 Sep 2012 14:28:42 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Sep 2012 14:28:08 +0000 Received: by mail.ecoscentric.com (Postfix, from userid 48) id B553A2F7800F; Mon, 3 Sep 2012 15:28:07 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: unassigned@bugs.ecos.sourceware.org Subject: [Bug 1001665] New: Typo in hal_stm32_dma_isr return value X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: HAL X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: alan.bowman@datong.co.uk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 03 Sep 2012 14:28:00 -0000 Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-bugs-owner@sourceware.org X-SW-Source: 2012/txt/msg01241.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001665 Summary: Typo in hal_stm32_dma_isr return value Product: eCos Version: CVS Platform: stm32e_eval (ST STM3210E EVAL board) OS/Version: Cortex-M Status: UNCONFIRMED Severity: normal Priority: low Component: HAL AssignedTo: unassigned@bugs.ecos.sourceware.org ReportedBy: alan.bowman@datong.co.uk CC: ecos-bugs@ecos.sourceware.org Class: Advice Request The variable "ret" is initialised with CYG_ISR_HANDLED, and the used as the return value. It looks like there are no circumstances where this ISR does not handle this vector. However, ret is modified to CYG_ISR_CALL_DSR when the if statement is followed. I think that CYG_ISR_CALL_DSR should have been OR'd in to ret. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.