public inbox for ecos-bugs@sourceware.org help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org To: unassigned@bugs.ecos.sourceware.org Subject: [Bug 1001814] Kinetis clock gating Date: Sat, 06 Apr 2013 12:47:00 -0000 [thread overview] Message-ID: <bug-1001814-777-of4lybtsMZ@http.bugs.ecos.sourceware.org/> (raw) In-Reply-To: <bug-1001814-777@http.bugs.ecos.sourceware.org/> Please do not reply to this email, use the link below. http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001814 Ilija Kocho <ilijak@siva.com.mk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2155|0 |1 is obsolete| | --- Comment #4 from Ilija Kocho <ilijak@siva.com.mk> --- Created attachment 2162 --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2162&action=edit Kinetis HAL clock gating (fix, ref comment 3) Mike (In reply to comment #3) > Ilija, > > I think the problem was you incorporated part of my GPIO patch and I patched > against my changes rather than a fresh tree. So with some hand editing I > fixed it. I can run my applications tomorrow to make sure nothing breaks and > perhaps play with the added API a little to turn off what I am not using. Thank you for the catch. It is there by accident. I used the same eCos repsitory for testing of your contribution and it slipped of my mind. Here I post a fixed patch. > > I noticed the datasheet says in section 5.6 the peripheral should be > disabled before stopping their clock. I did not look, but is there API > similar to these > > +__externC void hal_clock_enable( cyg_uint32 clkcd ); > +__externC void hal_clock_disable( cyg_uint32 clkcd ); > > for disabling peripherals? If not, I wonder if the clock API should handle > that at the same time. I assume that stopping a clock and then enabling it > again with the peripheral enabled might lead to unpredictable behavior. > Perhaps disable clock should disable the peripheral. I am not sure I would > want it to enable it, in case some setup was required before starting the > clock. Devices with disabled clock are inaccessible. Some are simply silent, but for majority, access attempt raises exception. Besides this some devices have some kind of enable feature. But there's no general rule, therefore it's up to the device driver to take care of that. Ilija -- You are receiving this mail because: You are the assignee for the bug.
next prev parent reply other threads:[~2013-04-06 12:47 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-04 19:43 [Bug 1001814] New: " bugzilla-daemon 2013-04-04 19:44 ` [Bug 1001814] " bugzilla-daemon 2013-04-04 19:58 ` bugzilla-daemon 2013-04-06 5:49 ` bugzilla-daemon 2013-04-06 6:17 ` bugzilla-daemon 2013-04-06 12:47 ` bugzilla-daemon [this message] 2013-04-06 12:49 ` bugzilla-daemon 2013-04-06 13:06 ` bugzilla-daemon 2013-04-06 13:54 ` bugzilla-daemon 2013-04-06 13:57 ` bugzilla-daemon 2013-04-06 14:00 ` bugzilla-daemon 2013-04-06 14:08 ` bugzilla-daemon 2013-04-06 14:21 ` bugzilla-daemon 2013-04-06 14:24 ` bugzilla-daemon 2013-04-06 14:37 ` bugzilla-daemon 2013-04-06 14:54 ` bugzilla-daemon 2013-04-06 15:47 ` bugzilla-daemon 2013-04-06 16:34 ` bugzilla-daemon 2013-04-06 17:21 ` bugzilla-daemon 2013-04-06 17:40 ` bugzilla-daemon 2013-04-07 5:39 ` bugzilla-daemon 2013-04-07 7:13 ` bugzilla-daemon 2013-04-07 10:41 ` bugzilla-daemon 2013-04-07 13:52 ` bugzilla-daemon 2013-04-07 14:18 ` bugzilla-daemon 2013-04-07 16:44 ` bugzilla-daemon 2013-04-15 22:29 ` bugzilla-daemon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-1001814-777-of4lybtsMZ@http.bugs.ecos.sourceware.org/ \ --to=bugzilla-daemon@bugs.ecos.sourceware.org \ --cc=unassigned@bugs.ecos.sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).