public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001879] New: Kinetis DSPI infinite polling
Date: Tue, 09 Jul 2013 17:54:00 -0000	[thread overview]
Message-ID: <bug-1001879-777@http.bugs.ecos.sourceware.org/> (raw)

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001879

            Bug ID: 1001879
           Summary: Kinetis DSPI infinite polling
           Product: eCos
           Version: CVS
            Target: freescale_twr_k70f120m (Freescale Kinetis TWR-K70F120M
                    board)
  Architecture/Host Cortex-M
                OS:
            Status: UNCONFIRMED
          Severity: normal
          Priority: low
         Component: SPI
          Assignee: unassigned@bugs.ecos.sourceware.org
          Reporter: mjones@linear.com
                CC: ecos-bugs@ecos.sourceware.org

Created attachment 2322
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2322&action=edit
DSPI Polling Patch

I believe I have found the source of all my intermittent MMC/SD problems
discussed in bug 10011764. (Note, this does not apply to the 4GB Samsung Card
issue) I was fortunate to finally have a persistent failure that I could debug.

The problem is related to polling in file api_freescale_spi.c.

There is a function called dspi_transaction_end(...) and this function has the
following code:

DSPI_EOQ_CLEAR(dspi_p);
while(!(dspi_p->sr & FREESCALE_DSPI_SR_EOQF_M));

Sometimes execution hangs on the while.

I believe the problem is that the clear sometimes clears before the bit is set,
and sometimes it clears after. There is a race condition between the code and
the peripheral.

I believe the code should be:

while(!(dspi_p->sr & FREESCALE_DSPI_SR_EOQF_M));
DSPI_EOQ_CLEAR(dspi_p);

which clears the bit after the polling is satisfied.

As soon as I made this change, all my problems disappeared. I verified that my
application can now read/write the SD. My application that logs telemetry to SD
will now run for a long time without failure. I retested several SD cards and
they are fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.


             reply	other threads:[~2013-07-09 17:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 17:54 bugzilla-daemon [this message]
2013-07-09 17:54 ` [Bug 1001879] " bugzilla-daemon
2013-07-09 20:52 ` bugzilla-daemon
2013-07-09 23:09 ` bugzilla-daemon
  -- strict thread matches above, loose matches on Subject: below --
2013-07-09 17:54 [Bug 1001879] New: " bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1001879-777@http.bugs.ecos.sourceware.org/ \
    --to=bugzilla-daemon@bugs.ecos.sourceware.org \
    --cc=unassigned@bugs.ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).