From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17747 invoked by alias); 27 Nov 2006 10:19:16 -0000 Received: (qmail 17733 invoked by uid 22791); 27 Nov 2006 10:19:15 -0000 X-Spam-Status: No, hits=2.1 required=5.0 tests=AWL,BAYES_50,RCVD_NUMERIC_HELO,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from server.cct.co.uk (HELO SERVER.cct.co.uk) (195.11.24.1) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 27 Nov 2006 10:19:05 +0000 Received: from 192.67.84.200 ([192.67.84.200]) by SERVER.cct.co.uk ([10.12.10.1]) with Microsoft Exchange Server HTTP-DAV ; Mon, 27 Nov 2006 10:18:36 +0000 Received: from software.cct.co.uk by mail.cct.co.uk; 27 Nov 2006 10:19:47 +0000 Subject: Possible bug with CYGSEM_REDBOOT_NETWORK_INIT_ONE_DEVICE From: David Fernandez Reply-To: dfernandez@cct.co.uk To: ecos-devel@ecos.sourceware.org Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Concurrent Technologies, Plc Date: Mon, 27 Nov 2006 10:19:00 -0000 Message-Id: <1164622786.7152.32.camel@software.cct.co.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Mailing-List: contact ecos-devel-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-devel-owner@ecos.sourceware.org X-SW-Source: 2006-11/txt/msg00031.txt.bz2 Hi there, I'was about to use the feature CYGSEM_REDBOOT_NETWORK_INIT_ONE_DEVICE, and I've noticed that may be it doesn't work as per the description in the cdl option: It says that it should stop initializing network devices as soon as one is initialized successfully. But it seems that the initialization logic for a default interface has someway confused the things. It tries to initialize the default interface, but if it fails, then it seems to initialize all of them... I think there should be a break statement within the "if (t->init())" block (net_io.c: net_init()) if this options is active and enabled. May be the we can get rid of CYGSEM_REDBOOT_FLASH_CONFIG condition in CYGDAT_REDBOOT_DEFAULT_NETWORK_DEVICE (doing the appropriate changes in net_io.c: net_init()), so we could provide a default interface if there is no flash configured. Anybody thinks a patch to change all this is interesting?