From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2373 invoked by alias); 21 Nov 2008 17:08:13 -0000 Received: (qmail 2300 invoked by uid 22791); 21 Nov 2008 17:08:12 -0000 X-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,SARE_PROLOSTOCK_SYM3,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from anika.2020media.com (HELO smtp.2020smtp.net) (212.124.192.214) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Nov 2008 17:07:24 +0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=wibb3e; d=2020media.com; h=Received:Subject:From:To:Cc:In-Reply-To:References:Content-Type:Organization:Date:Message-Id:Mime-Version:X-Mailer:Content-Transfer-Encoding:X-2020-Relay; b=I6wQT2lixrEJTjdHGxDa2Y54YLi1UUY785wwTVID/BvbtstQyJdsVXH9HJ52srtAKKZQVT4Mmq8bYJNb7EGO9pF2zKI7Og0A4VJKdXu2vU0Ea9xUOqZa0W6irMlDgWSg; Received: from [212.124.199.38] (helo=[192.168.0.2]) by smtp.2020smtp.net with esmtp (Exim 4.63) (envelope-from ) id 1L3ZTb-00006I-Fo; Fri, 21 Nov 2008 17:07:27 +0000 Subject: Re: STM32 - I/O pullup and EXTI issues, plus new SPI driver. From: Chris Holgate To: Nick Garnett Cc: ecos-devel@ecos.sourceware.org In-Reply-To: References: <1227280292.8476.47.camel@hercules.zynaptic.com> Content-Type: text/plain Organization: Zynaptic Limited Date: Fri, 21 Nov 2008 17:08:00 -0000 Message-Id: <1227287580.8476.74.camel@hercules.zynaptic.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1.1 Content-Transfer-Encoding: 7bit X-2020-Relay: Sent using 2020MEDIA.net.uk relay with auth code: Send Abuse reports to abuse@2020media.net.uk X-IsSubscribed: yes Mailing-List: contact ecos-devel-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-devel-owner@ecos.sourceware.org X-SW-Source: 2008-11/txt/msg00051.txt.bz2 On Fri, 2008-11-21 at 15:52 +0000, Nick Garnett wrote: > Chris Holgate writes: > > > > 1) It's not possible to set pullups on I/Os using the provided > > functions. This is a trivial one-line fix to stm32-misc.c. > > > > 2) External interrupts don't work as they stand. This requires a few > > changes to the STM32 var_intr.h. If required I can tidy up my changes > > there and provide a patch which I've tested using a single I/O > > (EXTINT0), but which would probably benefit from a bit more testing > > using other I/O configurations. > > I can easily believe that both of these don't quite work. I didn't do > much testing in this area, so any changes to make it work are appreciated. OK - Simon has offered to review the changes, so I'll let him look them over and once the copyright assignment is through you can decide what to do with them. > > FYI, I now have a DMA-based SPI driver that is fully functional in > > kernel mode, but will need one or two changes (and some testing!) to > > make it play nicely in non-kernel mode. Probably best to leave that > > until the 3.0 release is done, though. > > You can mainly test polled operation in the kernel just by temporarily > forcing the polled parameter to true. Polled operation works, but I'm going to have to sprinkle a few preprocessor directives in there to get rid of my calls to the kernel flags API. Is there any reason why flags support didn't make it into the standard driver API? I find that it's much more elegant than using condition variables in a lot of cases. Chris.