From: Andrew Lunn <andrew@lunn.ch>
To: "Neundorf, Alexander" <Alexander.Neundorf@jenoptik.com>
Cc: ecos-devel@ecos.sourceware.org
Subject: Re: contributing filesystem and a failsafe update meachanism for FIS from within ecos applications
Date: Thu, 06 Oct 2005 07:22:00 -0000 [thread overview]
Message-ID: <20051006072156.GF28077@lunn.ch> (raw)
In-Reply-To: <5A8A17126B73AC4C83968F6C4505E3C502CAD202@JO-EX01.JENOPTIK.NET>
On Thu, Oct 06, 2005 at 08:44:58AM +0200, Neundorf, Alexander wrote:
>
>
> > Von: ecos-devel-owner@ecos.sourceware.org
> >
> > Hi,
> >
> > it's not even one year ago, and already I have the next
> > version of my patch available ;-)
> >
> > The attached patch implements a read-only filesystem for FIS,
> > and three extra utility functions for manipulating it safely
> > from ecos applications.
>
> Any comments ?
The same onces as last year.
You should also take a look at locking. You have some locking between
the FS and the functions, but it has race conditions. The locking the
other way does not exist at all.
You also incorrectly use st_mode, but that is minor.
Andrew
next prev parent reply other threads:[~2005-10-06 7:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-06 6:45 AW: " Neundorf, Alexander
2005-10-06 7:22 ` Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-23 13:11 Daly, Jeffrey
2005-09-23 12:09 Neundorf, Alexander
2005-09-23 13:02 ` Jon Ringle
2005-09-23 13:33 ` Gary Thomas
2005-09-23 18:06 ` Tarmo Pikaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051006072156.GF28077@lunn.ch \
--to=andrew@lunn.ch \
--cc=Alexander.Neundorf@jenoptik.com \
--cc=ecos-devel@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).