From: Andrew Lunn <andrew@lunn.ch>
To: "Doyle, Patrick" <Patrick_Doyle@dtccom.com>
Cc: "'ecos-devel@sources.redhat.com'" <ecos-devel@sources.redhat.com>,
'Andrew Dyer' <adyer@righthandtech.com>
Subject: Re: RedBoot patches regarding redboot_getc_terminate
Date: Thu, 18 May 2006 13:26:00 -0000 [thread overview]
Message-ID: <20060518132621.GA11223@lunn.ch> (raw)
In-Reply-To: <F7F756E5ED50F345959AE893AD2F15660A222B@dtcsrvr09.dtccom.com>
On Thu, May 18, 2006 at 09:17:15AM -0400, Doyle, Patrick wrote:
> Sometime since September of 2005, we updated our local eCos repository,
> which includes Andrew Dyer's RedBoot patches to call
> 'redboot_getc_terminate()' in various error scenarios. Since that time, we
> have observed that anytime we use YMODEM to download code to our boards, it
> terminates with an error message.
>
> I hate training myself to ignore error messages... it always comes back to
> haunt me.
>
> So, I looked into this, and I see in 'load_elf_image()', near line 455 of
> "load.c", there is a call to 'redboot_getc_terminate()' with an an argument
> of 'true', indicating that the data transfer should be aborted. I changed
> the abort flag back to 'false', and things have returned to normal for us.
>
> However, before I submit a formal patch undoing the work that Andrew did
> (which had to do with terminating TFTP transfers gracefully), I thought I
> would check in with folks, Andrew especially.
>
> What do folks think? Should I generate the one line patch (along with the 5
> line ChangeLog entry)?
What happens to TFTP transfers with your change? Are they terminated
gracefully? Or do they hang around until the server times out and
kills them?
Andrew
next prev parent reply other threads:[~2006-05-18 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 13:18 Doyle, Patrick
2006-05-18 13:26 ` Andrew Lunn [this message]
2006-05-18 13:32 Doyle, Patrick
2006-05-18 13:40 Doyle, Patrick
2006-05-18 13:54 ` Andrew Lunn
2006-05-18 15:00 ` David Vrabel
2006-05-18 15:14 ` Andrew Lunn
2006-05-18 15:59 ` David Vrabel
2006-05-18 16:59 Doyle, Patrick
2006-05-20 0:08 Andrew Dyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060518132621.GA11223@lunn.ch \
--to=andrew@lunn.ch \
--cc=Patrick_Doyle@dtccom.com \
--cc=adyer@righthandtech.com \
--cc=ecos-devel@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).