public inbox for ecos-devel@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Doyle, Patrick" <Patrick_Doyle@dtccom.com>
Cc: 'Andrew Lunn' <andrew@lunn.ch>,
		"'ecos-devel@sources.redhat.com'"
	<ecos-devel@sources.redhat.com>,
		'Andrew Dyer' <adyer@righthandtech.com>
Subject: Re: RedBoot patches regarding redboot_getc_terminate
Date: Thu, 18 May 2006 13:54:00 -0000	[thread overview]
Message-ID: <20060518135448.GB11223@lunn.ch> (raw)
In-Reply-To: <F7F756E5ED50F345959AE893AD2F15660A222D@dtcsrvr09.dtccom.com>

On Thu, May 18, 2006 at 09:39:12AM -0400, Doyle, Patrick wrote:
> > 
> > What happens to TFTP transfers with your change? Are they terminated
> > gracefully? Or do they hang around until the server times out and
> > kills them?
> > 
> >       Andrew
> > 
> Unfortunately, I don't have any means to check that.  Which is why I brought
> it up as a topic for discussion.  Then I realized that it would be easier to
> discuss if somebody who _did_ have a means to check that checked that, which
> led to me posting the patch :-)
> 
> IIRC, a TFTP server will keep spewing out packets until it has sent the
> whole file, and will retry and retransmit if the client stops responding.
> So, it guess it depends on what the TFTP transport stream (implemented in
> code somewhere in RedBoot) does when it gets a "terminate" call that isn't
> an abort...
> 
> Hmmm... looking at the code, I see something that looks like:
> 
> if (abort)
>   tftp_error_ack(...)
> else
>   tftp_ack(...)
> 
> which looks to me like TFTP folks would be getting some sort of similar
> error message for TFTP transfers.

Well, it would depend on the exact error returned to the TFTP server. 

[Goes and looks at the code][Goes and looks at the RFC]

7. Premature Termination

   If a request can not be granted, or some error occurs during the
   transfer, then an ERROR packet (opcode 5) is sent.  This is only a
   courtesy since it will not be retransmitted or acknowledged, so it
   may never be received.  Timeouts must also be used to detect errors.

It looks like reporting an error is the only way to abort the rest of
the transfer. Depending on the TFTP server it might put a comment in
/var/log/syslog etc, but most users don't read that unless something
serious has gone wrong.

I suggest for [X-Z]modem you read the RFC or whatever and find out if
there is a graceful way of closing the connection, as opposed to a
none graceful way which it currently seems to be doing according to
your report.

     Andrew

  reply	other threads:[~2006-05-18 13:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-18 13:40 Doyle, Patrick
2006-05-18 13:54 ` Andrew Lunn [this message]
2006-05-18 15:00 ` David Vrabel
2006-05-18 15:14   ` Andrew Lunn
2006-05-18 15:59     ` David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2006-05-20  0:08 Andrew Dyer
2006-05-18 16:59 Doyle, Patrick
2006-05-18 13:32 Doyle, Patrick
2006-05-18 13:18 Doyle, Patrick
2006-05-18 13:26 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060518135448.GB11223@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Patrick_Doyle@dtccom.com \
    --cc=adyer@righthandtech.com \
    --cc=ecos-devel@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).