From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2828 invoked by alias); 19 Nov 2006 22:51:32 -0000 Received: (qmail 2819 invoked by uid 22791); 19 Nov 2006 22:51:32 -0000 X-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from aibo.runbox.com (HELO aibo.runbox.com) (193.71.199.94) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 19 Nov 2006 22:51:25 +0000 Received: from [10.9.9.160] (helo=penny.runbox.com ident=Debian-exim) by greyhound.runbox.com with esmtp (Exim 4.50) id 1GlvVJ-0003L1-5t; Sun, 19 Nov 2006 23:51:13 +0100 Received: from 68-233-42-85.bflony.adelphia.net ([68.233.42.85] helo=[127.0.0.1]) by penny.runbox.com with esmtpa (uid:230665 ) (Exim 4.50) id 1GlvVG-0004sJ-3S; Sun, 19 Nov 2006 23:51:12 +0100 Message-ID: <4560DFDC.5090804@runbox.com> Date: Sun, 19 Nov 2006 22:51:00 -0000 From: John Clark User-Agent: Thunderbird 1.5.0.8 (Windows/20061025) MIME-Version: 1.0 To: Andrew Lunn CC: ecos-devel@sourceware.org Subject: Re: Redboot load command is crippled References: <45605202.7020207@runbox.com> <20061119160049.GA20731@lunn.ch> In-Reply-To: <20061119160049.GA20731@lunn.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-devel-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: ecos-devel-owner@ecos.sourceware.org X-SW-Source: 2006-11/txt/msg00008.txt.bz2 Hello Andrew, Your patch matches what I have already done to get it to work for me. Without that change, it would never write anything to memory through the addr pointer if the address was outside of the memory range known to Redboot on the PC platform (beyond the first 640K). My only concern now is that the "Allow the load-command write into Flash" (CYGBLD_REDBOOT_LOAD_INTO_FLASH) option requires that "Validate RAM addresses during load" (CYGSEM_REDBOOT_VALIDATE_USER_RAM_LOADS) option be enabled as well. Otherwise, the code assuming that an invalid RAM address is a flash address just won't work. - John Andrew Lunn wrote: > Hi John. > > How does it break the load? Please could you try the attached patch. > > Thanks > > Andrew >