From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13570 invoked by alias); 15 Jan 2009 17:02:12 -0000 Received: (qmail 13410 invoked by uid 22791); 15 Jan 2009 17:02:10 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37,SPF_PASS X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Jan 2009 17:01:22 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 0EE943B4003E; Thu, 15 Jan 2009 17:01:19 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nwLYiuiRqne6; Thu, 15 Jan 2009 17:01:11 +0000 (GMT) Message-ID: <496F6BD6.3040001@eCosCentric.com> Date: Thu, 15 Jan 2009 17:02:00 -0000 From: Jonathan Larmour User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Evgeniy Dushistov CC: ecos-discuss@ecos.sourceware.org, ecos-devel@ecos.sourceware.org Subject: Re: [ECOS] at91sam9263ek support ver. beta 1 References: In-Reply-To: OpenPGP: id=A5FB74E6 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-devel-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-devel-owner@ecos.sourceware.org X-SW-Source: 2009-01/txt/msg00030.txt.bz2 Hi Evgeniy, Thanks for working on this. Evgeniy Dushistov wrote: > > I need this changes, because of at91sam9 use the same code as arm9 to > work with caches: > http://sites.google.com/site/duhistov/Home/0003-rename-all-hal_cache.h-to-var_cache.h-and-copy-creat.patch?attredirects=0 Urk. There are easier ways to do this. And in any case, putting ARM9-specific code in the architecture HAL is not right. Even with that addressed, it will break a lot of people's ports out there (not in anoncvs). That's something which should not be done lightly - I don't mean it can never be done, but it should be avoided and in this case can be. And in fact, should be because that's what the name "var_cache.h" signifies - a different processor variant, whereas in your patch it's used for platform ports too, most of which have the same variant. I think the main problem is that we have separate processor HALs for ARM9, XScale, etc. But not for ARM7. There should be probably be an ARM7 processor variant HAL to deal with bits which are specific to that. That's where hal_cache.h would live, along with anything else that isn't shared with other processor variants, but is shared with other ARM7's. This would also open up the possibility in future of breaking out some code in vectors.S which currently has to cater for the lowest-common-denominator instruction set of ARM architecture v4. It would be nice to be able to use better instructions in some places, and thumb in particular is simpler in later architecture versions. Adding a new CYGPKG_HAL_ARM_ARM7 to the target definition in ecos.db is a much simpler change. > Common part for working with arm9 mmu, move it to common files, because > of I see a lot of duplication in hal/arm/arm9: > http://sites.google.com/site/duhistov/Home/0004-move-common-for-arm9-code-for-work-with-mmu-into-com.patch?attredirects=0 Again ARM9 code in the architecture HAL is not appropriate. It should live in the ARM9 processor variant HAL. With a new file, or via something included from hal_mmu.h via a HAL-provided option. As it stands this would break a lot of people's own ports outside of anoncvs because of duplicated definitions (even once moved to the ARM9 HAL) - this can be avoided in this case by changing the macro names, e.g. by prefixing "CYGARC_HAL_". > Some time ago(several weeks or whole month), I sent request to fsf, > about assigning copyrights, but have no reply, may be they just drop my > email. They have a backlog after the christmas break, but I would have thought they should have got through it by now. If you are worried it may have been lost, send a mail to assign [AT] fsf.org Jifl -- eCosCentric Limited http://www.eCosCentric.com/ The eCos experts Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571 Registered in England and Wales: Reg No 4422071. ------["Si fractum non sit, noli id reficere"]------ Opinions==mine