public inbox for ecos-devel@sourceware.org
 help / color / mirror / Atom feed
From: John Dallaway <john@dallaway.org.uk>
To: Simon Kallweit <simon.kallweit@intefo.ch>
Cc: eCos development list <ecos-devel@ecos.sourceware.org>,
	        John Eigelaar <john@kses.net>
Subject: Re: lwIP upgrade to CVS HEAD
Date: Fri, 08 May 2009 15:56:00 -0000	[thread overview]
Message-ID: <4A045625.9080706@dallaway.org.uk> (raw)
In-Reply-To: <4A0022F9.5020207@intefo.ch>

Hi Simon

John Dallaway wrote:

> I will review the CDL.

The CDL is looking good so far.

There's some scope for improving the dependency info. For example,
CYGIMP_LWIP_MEMP_MEM_MALLOC could specify:

   requires { CYGINT_ISO_MEMALLOC != 0 }
   default_value { CYGINT_ISO_MEMALLOC != 0 }

Many of the protocol components and options are also likely to "require"
either CYGPKG_LWIP_TCP or CYGPKG_LWIP_UDP.

There may also be some scope for active_if constraints to clarify the
relevance of certain options. For example, could CYGPKG_LWIP_NETCONF be
made "active_if !CYGPKG_LWIP_DHCP"? This may not be possible if the
static networking address definitions are still required for correct
compilation when DHCP is enabled.

Finally, I would make the display strings of the numerous protocol
support components and options just a little more verbose. For example:

  "DHCP" -> "DHCP support"
  "ICMP" -> "ICMP support"

and so on.

There are currently 27 items directly under the lwIP package node in the
tree. Perhaps there is some scope for further grouping of these nodes to
give the tree more depth and less breadth. For example, a "Protocol
support" component of "flavor none" containing the various protocol
components?

>> The sequential API is required for the socket API and desirable in its
>> own right as it provides a good compromise between ease of use and
>> memory footprint. John Eigelaar has indicated that he would be willing
>> to help with this and already has a copyright assignment in place.
> 
> Any help is appreciated. I will gladly help testing and do work on this
> too, when there is need. But I would like to have John Eigelaar commit
> his changes and go from there instead of going from scratch.
> 
>> We will need more functionality in place before we can replace the
>> existing lwIP port in the eCos repository trunk. We could use your own
>> tree or we could cut a branch in the eCos repository. I would prefer to
>> branch the eCos repository as this would enhance visibility within the
>> eCos community, gives a better sense of shared ownership, and allows the
>> eCos maintainers to monitor progress more easily. Be assured that I am
>> keen to support this lwIP port update and will ensure that patches are
>> committed to the branch quickly.
> 
> I think that's a good idea.

OK. Send me a tarball of the updated package when you're ready to start
collaborating and I'll check it in on a new branch.

John Dallaway

  reply	other threads:[~2009-05-08 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <49F83C8B.9000108@intefo.ch>
2009-05-05 10:31 ` John Dallaway
2009-05-05 11:29   ` Simon Kallweit
2009-05-08 15:56     ` John Dallaway [this message]
2009-05-13 16:03       ` Simon Kallweit
2009-05-14 13:27 David Fernandez
2009-05-14 13:31 ` Simon Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A045625.9080706@dallaway.org.uk \
    --to=john@dallaway.org.uk \
    --cc=ecos-devel@ecos.sourceware.org \
    --cc=john@kses.net \
    --cc=simon.kallweit@intefo.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).