From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27376 invoked by alias); 21 Aug 2009 07:42:39 -0000 Received: (qmail 27367 invoked by uid 22791); 21 Aug 2009 07:42:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,HS_INDEX_PARAM X-Spam-Check-By: sourceware.org Received: from mtaout02-winn.ispmail.ntl.com (HELO mtaout02-winn.ispmail.ntl.com) (81.103.221.48) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Aug 2009 07:42:26 +0000 Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout02-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090821074223.GHQG6611.mtaout02-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com>; Fri, 21 Aug 2009 08:42:23 +0100 Received: from cog.dallaway.org.uk ([86.9.207.237]) by aamtaout01-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090821074223.MEIR13254.aamtaout01-winn.ispmail.ntl.com@cog.dallaway.org.uk>; Fri, 21 Aug 2009 08:42:23 +0100 Received: from cog.dallaway.org.uk (cog.dallaway.org.uk [127.0.0.1]) by cog.dallaway.org.uk (8.13.8/8.13.8) with ESMTP id n7L7gK2W022305; Fri, 21 Aug 2009 08:42:20 +0100 Message-ID: <4A8E4FDC.5020804@dallaway.org.uk> Date: Fri, 21 Aug 2009 07:42:00 -0000 From: John Dallaway User-Agent: Thunderbird 2.0.0.22 (X11/20090625) MIME-Version: 1.0 To: Simon Kallweit CC: ecos-devel@ecos.sourceware.org Subject: Re: lwip 1.3.1 package References: <4A8D505C.3010907@intefo.ch> In-Reply-To: <4A8D505C.3010907@intefo.ch> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-devel-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-devel-owner@ecos.sourceware.org X-SW-Source: 2009-08/txt/msg00035.txt.bz2 Hi Simon Simon Kallweit wrote: > I have updated my lwIP package with the final 1.3.1 release. There are > changes in two areas, and I wonder how to tackle them: > > 1. SLIP polling support > > I changed the SLIP netif to support polling, so it does not need to run > in it's own thread when resources are low. I submitted the patch to lwip > quite a bit of time ago, but there were no reactions: > > http://savannah.nongnu.org/bugs/?26397 > > I could of course remove my changes, but then the eCos package will not > support SLIP in the simple/polled mode. So I'd also have to change some > of the glue code. I would rather like to keep SLIP polling support in. I see that Kieran Mansley has replied to your recent follow up on bug 26397. If you can persuade him to accept the patch it would be good to keep your SLIP polling support in the eCos package. No need to wait for the next lwIP release. > 2. PPP > > There are quite a bit of changes I made to the PPP code: > > * put code more in line with lwip coding style (mostly renaming) > * added a simple chat component, to connect a modem to the peer > * added support for PPP dumps (wireshark) > * added polling support > * added an eCos testcase (only for simple/polled mode) > > If I restore the original PPP code as suggested, I will also have to > adapt the glue code and configuration. I would remove the testcase and > generally mark PPP as experimental. The other way would be to try and > clean PPP more up, and get the changes commited to lwip, but then we > would have to wait for another release. The two scenarios are: a) Your PPP changes are built upon over time by you and/or other people and ultimately accepted into lwIP. b) PPP is fixed in lwIP in a different way, rendering your patches incompatible and obsolete. Which do you think is the more likely scenario based on your knowledge of the lwIP project and your own availability/inclination to work on PPP? John Dallaway