From: John Dallaway <john@dallaway.org.uk>
Cc: Uwe Kindler <uwe_kindler@web.de>, ecos-devel@sourceware.org
Subject: Re: uSTL config.h clash
Date: Sat, 29 Aug 2009 20:26:00 -0000 [thread overview]
Message-ID: <4A998ECA.5050200@dallaway.org.uk> (raw)
In-Reply-To: <4A9984BA.7040705@dallaway.org.uk>
Hi Uwe
John Dallaway wrote:
> Uwe Kindler wrote:
>
>> if I move the all uSTL headers except of ustl.h into an ustl
>> subdirectory, then I need to touch almost all include directives in the
>> ustl header and source files. I.e. in unew.c I would replace #include
>> "unew.h" by #include "ustl/unew.h". Did I understand this right?
>
> I've just taken a quick look at the sources. It is indeed unfortunate
> that the #includes in the various header files do not specify the ustl/
> subdirectory like ustl.h does in the upstream sources. The quick fix
> here is to rename config.h to something like ustlcfg.h as you suggest.
> But I'm concerned that other conflicts may arise in the future.
>
> Why does the original author make a distinction between include paths in
> ustl.h and in the other ustl header files?
To answer my own question, I now note that the original code uses a
ustl/ symlink.
I think the correct long-term approach for eCos is to move the header
files (other than ustl.h) into include/ustl/ and to modify the source
code accordingly. This will involve changes to many files but the
changes are trivial and can be applied using a simple substitution so
this should not impact future code imports much. If you agree with this
approach, I will make the changes.
John Dallaway
next prev parent reply other threads:[~2009-08-29 20:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 16:58 Uwe Kindler
2009-08-29 19:43 ` John Dallaway
2009-08-29 20:26 ` John Dallaway [this message]
2009-08-29 21:25 ` Uwe Kindler
2009-08-29 21:30 ` Uwe Kindler
2009-08-30 17:39 ` John Dallaway
-- strict thread matches above, loose matches on Subject: below --
2009-08-28 16:33 John Dallaway
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A998ECA.5050200@dallaway.org.uk \
--to=john@dallaway.org.uk \
--cc=ecos-devel@sourceware.org \
--cc=uwe_kindler@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).