From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21631 invoked by alias); 27 Oct 2009 13:06:28 -0000 Received: (qmail 21622 invoked by uid 22791); 27 Oct 2009 13:06:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mail04.solnet.ch (HELO mail04.solnet.ch) (212.101.4.138) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Oct 2009 13:06:21 +0000 Received: from mail04.solnet.ch ([127.0.0.1]) by localhost (mail04.solnet.ch [127.0.0.1]) (SolNet-Check, port 10024) with LMTP id WLqpyyZUc3mv; Tue, 27 Oct 2009 13:06:02 +0000 (UTC) Received: from beta.intefo.ch (static-212-101-18-64.adsl.solnet.ch [212.101.18.64]) by mail04.solnet.ch (Postfix) with ESMTP id 59559873D7; Tue, 27 Oct 2009 13:05:57 +0000 (UTC) Received: from beta.intefo.ch ([127.0.0.1]) by localhost (beta.intefo.ch [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sRXbHRFuI0HF; Tue, 27 Oct 2009 14:05:50 +0100 (CET) Received: from [192.168.1.20] (simon.intefo.ch [192.168.1.20]) by beta.intefo.ch (Postfix) with ESMTP id EA09F770264; Tue, 27 Oct 2009 14:05:50 +0100 (CET) Message-ID: <4AE6F04B.3060505@intefo.ch> Date: Tue, 27 Oct 2009 13:06:00 -0000 From: Simon Kallweit User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: John Dallaway CC: ecos-devel@ecos.sourceware.org Subject: Re: lwip 1.3.1 testing References: <4A8E48C2.10802@intefo.ch> <20090821184336.GA24882@ubuntu.local> <20090824201853.GA10163@ubuntu.local> <4A938008.70909@intefo.ch> <4A939599.8040703@intefo.ch> <4AE480E7.2010803@dallaway.org.uk> <4AE59D93.30000@intefo.ch> <4AE5A9FB.8020801@dallaway.org.uk> <4AE5B235.3050905@intefo.ch> <4AE5D8B7.9070809@dallaway.org.uk> In-Reply-To: <4AE5D8B7.9070809@dallaway.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact ecos-devel-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-devel-owner@ecos.sourceware.org X-SW-Source: 2009-10/txt/msg00064.txt.bz2 John Dallaway wrote: > I would recommend a "radio button" approach for mutually exclusive modes > which have associated source files. Something like: > > cdl_interface CYGINT_LWIP_MODES { > display "Enabled lwIP modes" > no_define > requires 1 == CYGINT_LWIP_MODES > description "This interface is used to force mutually exclusive > selection of the available lwIP modes." > } > cdl_option CYGFUN_LWIP_MODE_SIMPLE { > display "Simple mode" > implements CYGINT_LWIP_MODES > compile ecos/simple.c > } > cdl_option CYGFUN_LWIP_MODE_SEQUENTIAL { > display "Sequential mode" > implements CYGINT_LWIP_MODES > compile ecos/sequential.c > } > >> The same applies to sio. I can add a new package CYGPKG_LWIP_SIO which >> is required by both PPPoS and SLIPIF. I think the best place would be >> the "APIs" section as the SIO may be also used for other purposes than >> lwIP's internal. So a user could enable sio without using SLIPIF or PPPoS. > > It would be best to use another CDL interface to enable compilation of > this code. Something like: > > cdl_interface CYGINT_LWIP_SIO_REQUIRED { > no_define > display "Items requiring lwIP serial operations" > description "Items requiring use of the lwIP serial operations code > should implement this interface." > } > cdl_option CYGFUN_LWIP_SIO { > display "Serial operations support" > calculated { CYGINT_LWIP_SIO_REQUIRED > 0 } > compile ecos/sio.c > } > cdl_component CYGPKG_LWIP_SLIP { > implements CYGINT_LWIP_SIO_REQUIRED > compile ... > ... > } > cdl_component CYGPKG_LWIP_PPP { > implements CYGINT_LWIP_SIO_REQUIRED > compile ... > ... > } > > This is a little more complicated than a simple "requires > CYGFUN_LWIP_SIO" but ensures that CYGFUN_LWIP_SIO becomes disabled when > the number of components requiring it falls to zero. I have adapted to CDL to reflect your recommendations. The new version can be fetched from http://download.westlicht.ch/lwip-20091027.tar.gz > I thought we had concluded that we should treat lwIP PPP as a separate > project which would require liaison with the upstream lwIP > maintainer(s). Is there anyone else in the eCos community who is able > and willing to work on this? True. I just wanted to point out that in it's current state PPP can only be used with simple mode. >>> One minor point: It would be very useful for the stack to report its own >>> IP address on the diagnostic channel. >> I'll try to implement this. I guess you're mainly talking about DHCP IPs >> right? > > Yes, although it might sometimes also be helpful to confirm a static IP > address. I have implemented reporting of the netif configuration for both static configuration and DHCP on the interfaces loopif, slipif and eth. This is configurable by CYGFUN_LWIP_SHOW_NETIF_CONFIG which is now enabled by default. Simon