From: Ilija Kocho <ilijak@siva.com.mk>
To: ecos-devel@ecos.sourceware.org
Subject: Re: tty.cdl
Date: Mon, 28 Mar 2011 19:00:00 -0000 [thread overview]
Message-ID: <4D90DAC3.3080209@siva.com.mk> (raw)
In-Reply-To: <alpine.DEB.2.00.1103281510310.14973@sg-desktop.belvok.com>
On 28.03.2011 14:16, Sergei Gavrikov wrote:
> On Mon, 28 Mar 2011, Ilija Kocho wrote:
>
>> On 27.03.2011 23:11, Sergei Gavrikov wrote:
>>> On Sun, 27 Mar 2011, Ilija Kocho wrote:
>>>
>>>> Sergei, I started this discussion in order to discuss this issue before
>>>> I drop any code. Your proposal sounds rational. I shall open a Bug and
>>>> reference this discussion.
>>> Ilija and may be not :-) I've seen that io_serial.h has
>>>
>>> #ifdef CYGDAT_IO_SERIAL_DEVICE_HEADER
>>> # include CYGDAT_IO_SERIAL_DEVICE_HEADER
>>> #endif
>>>
>>> So, your issue can be managed on the target's side, as both and tty.c
>>> and termios.c include this header. You can add CDL component in your HAL
>>> config file which parent should be CYGPKG_IO_SERIAL_TTY and define extra
>>> devices (TTY4, TTY5, ...) there. Also define/set your own value for the
>>> CYGDAT_IO_SERIAL_DEVICE_HEADER in the HAL's config file.
>>>
>> Sergei, thanks for remark. I tried it but produced file is included to
>> early as table definitions such as
>>
>> DEVTAB_ENTRY(tty_io4,
>> "/dev/tty4",
>> CYGDAT_IO_SERIAL_TTY_TTY4_DEV,
>> &tty_devio,
>> tty_init,
>> tty_lookup, // Execute this when device is being looked up
>> &tty_private_info4);
>>
>> depend on definitions included afterwards. Also file io_serial.h is
>> included in serial.c where produces errors.
>
> Yep. Then I noticed this catch too.
>
>> However the TTYs provided by devicel driver / HAL may be included at
>> proper place in tty.c later in similar way:
>>
>> #ifdef CYGDAT_IO_SERIAL_TTY_ADD
>> # include CYGDAT_IO_SERIAL_TTY_ADD
>> #endif
> Exactly.
>
>> I think these would be all changes to tty.c
> and the same for termios.c.
>
>> Should I continue this way?
> IMO, it is good solution (please, submit a patch to eCos Bugzilla).
Posted: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180
Thanks,
Ilija
next prev parent reply other threads:[~2011-03-28 19:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 10:22 tty.cdl Ilija Kocho
2011-03-26 18:33 ` tty.cdl Sergei Gavrikov
2011-03-27 11:40 ` tty.cdl Ilija Kocho
2011-03-27 12:45 ` tty.cdl Sergei Gavrikov
2011-03-27 15:46 ` tty.cdl Ilija Kocho
2011-03-27 17:11 ` tty.cdl Sergei Gavrikov
2011-03-27 19:34 ` tty.cdl Ilija Kocho
2011-03-27 19:39 ` tty.cdl Sergei Gavrikov
2011-03-27 19:55 ` tty.cdl Ilija Kocho
2011-03-27 21:11 ` tty.cdl Sergei Gavrikov
2011-03-28 10:42 ` tty.cdl Ilija Kocho
2011-03-28 12:16 ` tty.cdl Sergei Gavrikov
2011-03-28 19:00 ` Ilija Kocho [this message]
2011-03-28 19:25 ` tty.cdl Sergei Gavrikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D90DAC3.3080209@siva.com.mk \
--to=ilijak@siva.com.mk \
--cc=ecos-devel@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).