From: Andrew Parlane <andrewp@carallon.com>
To: ecos-devel@ecos.sourceware.org
Subject: Upgrading to LWIP 1.4.1
Date: Fri, 06 Dec 2013 12:10:00 -0000 [thread overview]
Message-ID: <52A1BE97.7020501@carallon.com> (raw)
A few months ago I did some work to port the latest stable LWIP to eCos.
Bug report: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001873
I'm trying to address the problems mentioned in comment 25, specifically
the ppp test not compiling.
PPP was one part that I didn't spend too much time looking at
originally, because I don't know much about it or have any means of
testing it. Looking again now, I see that when LWIP 1.3.2 was ported to
eCos, there was a patch applied along with the port (not as separate
patches) which is confusing matters. This extra patch seems to have
modified src/netif/ppp/ppp.c, and added to netif/ppp/ chat.c, timesys.c
timesys.h record.c, record.h and added include/netif/ppp/chat.h
From what I can gather the change to ppp.c was to fix PPP as LWIP 1.3.2
didn't support this properly, however LWIP 1.4.1 apparently does.
chat.c and .h seem to implement chat scripts which seems genuinely
useful, and is the reason the tests/ppp.c is failing to compile (because
I removed these). Adding these back is pretty trivial and should just work.
timesys and record were only used by src/netif/ppp/ppp.c and
specifically weren't required by the original LWIP code and were added
as part of this extra patch. I don't think these are needed anymore and
could just be removed.
Does anyone have any comments about any of this, does keeping chat.c and
.h and dropping the other files and extra changes to ppp.c seem sensible?
Finally while I'm happy to do this work including reapplying all the ppp
changes, I have no way of testing this, so would anyone be up for trying
these changes and making sure they work?
Thanks,
Andrew Parlane
reply other threads:[~2013-12-06 12:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A1BE97.7020501@carallon.com \
--to=andrewp@carallon.com \
--cc=ecos-devel@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).