public inbox for ecos-devel@sourceware.org
 help / color / mirror / Atom feed
From: Lars Poeschel <larsi@wh2.tu-dresden.de>
To: ecos-devel@ecos.sourceware.org
Subject: Error in eCosThreadUtils.h
Date: Tue, 14 Oct 2008 12:55:00 -0000	[thread overview]
Message-ID: <67EE2AE5-CB49-4D5A-9AC4-454194890597@wh2.tu-dresden.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

Hello!

Is there a bug in eCosThreadUtils.h line 64:

#ifndef NO_THREADS
	typedef int THREAD_ID;
#else
	typedef pthread_t THREAD_ID:
#endif

Shouldn't it be reversed, so that if NO_THREADS is defined that  
THREAD_ID is typdef'd as int ?
But the real question is: Is this still valid ? As I don't see that  
NO_THREADS could be defined somewhere.
It should either be replaced by a pthreads configure test or (which I  
would opt for) be removed completly (as well in eCosThreadUtils.cpp).

Regards,
Lars

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

                 reply	other threads:[~2008-10-14 12:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67EE2AE5-CB49-4D5A-9AC4-454194890597@wh2.tu-dresden.de \
    --to=larsi@wh2.tu-dresden.de \
    --cc=ecos-devel@ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).