public inbox for
 help / color / mirror / Atom feed
From: Bernd Edlinger <>
To: "" <>
Cc: "" <>
Subject: FW: RFC: bsd_tcpip patch on synch.c
Date: Thu, 27 Jun 2013 17:07:00 -0000	[thread overview]
Message-ID: <DUB124-W16336C51C7750AB4F51C4DE4750@phx.gbl> (raw)
In-Reply-To: <DUB124-W17E1B3022EDF1B00BF4396E4750@phx.gbl>


> After digging deep, I found that our problem was caused by something 
> else, so this fix is not needed, but we kept it because we did not like 
> that construct as you also point out.
>> If you really expect cyg_mutex_lock to ever return false,
>> then the right thing to do would be to assert(false)
>> and print a callstack or directly enter the debugger.
> No problem anymore..
> But is there a better way to loop over the mutex lock?

no, IMHO a simple "cyg_mutex_lock(&spl_mutex);" would have been enough.
But these patches are not about style at all.

But by the way there is another patch in that vicinitry:

That may apply to everyone who uses a tick count other than the default.


      parent reply	other threads:[~2013-06-27 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27  9:34 Lambrecht Jürgen
     [not found] ` <DUB124-W44EE5E989F221552E035FDE4750@phx.gbl>
2013-06-27 12:51   ` Bernd Edlinger
2013-06-27 14:20     ` Lambrecht Jürgen
     [not found]       ` <DUB124-W17E1B3022EDF1B00BF4396E4750@phx.gbl>
2013-06-27 17:07         ` Bernd Edlinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DUB124-W16336C51C7750AB4F51C4DE4750@phx.gbl \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).