From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31116 invoked by alias); 18 May 2006 13:18:18 -0000 Received: (qmail 30863 invoked by uid 22791); 18 May 2006 13:18:16 -0000 X-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_50,TW_WP X-Spam-Check-By: sourceware.org Received: from dns2-chi.paetec.net (HELO dns2-chi.paetec.net) (64.80.249.72) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 18 May 2006 13:18:02 +0000 Received: from dtcsrvr09.dtccom.com ([66.153.88.146]) by dns2-chi.paetec.net (8.13.6/8.13.6) with ESMTP id k4IDHnVE002481; Thu, 18 May 2006 09:17:54 -0400 (EDT) Received: by dtcsrvr09.dtccom.com with Internet Mail Service (5.5.2658.3) id ; Thu, 18 May 2006 09:17:16 -0400 Message-ID: From: "Doyle, Patrick" To: "'ecos-devel@sources.redhat.com'" Cc: "'Andrew Dyer'" Subject: RedBoot patches regarding redboot_getc_terminate Date: Thu, 18 May 2006 13:18:00 -0000 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2658.3) Content-Type: text/plain Mailing-List: contact ecos-devel-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: ecos-devel-owner@ecos.sourceware.org X-SW-Source: 2006-05/txt/msg00014.txt.bz2 Sometime since September of 2005, we updated our local eCos repository, which includes Andrew Dyer's RedBoot patches to call 'redboot_getc_terminate()' in various error scenarios. Since that time, we have observed that anytime we use YMODEM to download code to our boards, it terminates with an error message. I hate training myself to ignore error messages... it always comes back to haunt me. So, I looked into this, and I see in 'load_elf_image()', near line 455 of "load.c", there is a call to 'redboot_getc_terminate()' with an an argument of 'true', indicating that the data transfer should be aborted. I changed the abort flag back to 'false', and things have returned to normal for us. However, before I submit a formal patch undoing the work that Andrew did (which had to do with terminating TFTP transfers gracefully), I thought I would check in with folks, Andrew especially. What do folks think? Should I generate the one line patch (along with the 5 line ChangeLog entry)? --wpd Patrick Doyle Manager, Digital Systems Group DTC Communications, Inc. Phone: (603) 546-2179 Fax: (603) 880-6965 Email: wpd@dtccom.com This communication is from DTC Communications, Inc. and is intended to be confidential and solely for the use of the persons or entities addressed above. If you are not an intended recipient, be aware that the information contained herein may be protected from unauthorized use by privilege or law, and any copying, distribution, disclosure, or other use of this information is prohibited. If you have received this communication in error, please contact the sender by return e-mail or telephone the above number immediately and delete or destroy all copies. Thank you for your cooperation.