public inbox for ecos-devel@sourceware.org
 help / color / mirror / Atom feed
From: "Doyle, Patrick" <Patrick_Doyle@dtccom.com>
To: "'ecos-patches@ecos.sourceware.org'" 	
	<ecos-patches@ecos.sourceware.org>
Cc: "'ecos-devel@ecos.sourceware.org'" <ecos-devel@ecos.sourceware.org>
Subject: RE: RedBoot patches regarding redboot_getc_terminate
Date: Thu, 18 May 2006 13:32:00 -0000	[thread overview]
Message-ID: <F7F756E5ED50F345959AE893AD2F15660A222C@dtcsrvr09.dtccom.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

Ahh what the heck... here's the patch anyway, just to add a little more meat
to the discussion...

--wpd


[-- Attachment #2: redboot-load.patch --]
[-- Type: application/octet-stream, Size: 1578 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos/packages/redboot/current/ChangeLog,v
retrieving revision 1.237
diff -u -r1.237 ChangeLog
--- ChangeLog	30 Jan 2006 21:04:04 -0000	1.237
+++ ChangeLog	18 May 2006 13:25:01 -0000
@@ -1,3 +1,8 @@
+2006-05-18  Patrick Doyle  <wpd@dtccom.com>
+
+	* src/load.c (load_elf_image): Terminate ELF transfers gracefully
+	after reading all of the sections required by RedBoot.
+
 2005-11-23  Peter Korsgaard  <peter.korsgaard@barco.com>
 
 	* src/gunzip.c (do_gunzip): Fixed diag_printf format string warnings.
Index: src/load.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/redboot/current/src/load.c,v
retrieving revision 1.45
diff -u -r1.45 load.c
--- src/load.c	9 Sep 2005 13:26:03 -0000	1.45
+++ src/load.c	18 May 2006 13:25:01 -0000
@@ -430,10 +430,9 @@
         entry_address = ehdr.e_entry;
     }
 
-    // nak everything to stop the transfer, since redboot
-    // usually doesn't read all the way to the end of the
-    // elf files.
-    redboot_getc_terminate(true);
+    // Terminate the transfer gracefully at this point, since redboot
+    // usually doesn't read all the way to the end of the elf files.
+    redboot_getc_terminate(false);
     if (addr_offset) diag_printf("Address offset = %p\n", (void *)addr_offset);
     diag_printf("Entry point: %p, address range: %p-%p\n", 
                 (void*)entry_address, (void *)load_address, (void *)load_address_end);

             reply	other threads:[~2006-05-18 13:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-18 13:32 Doyle, Patrick [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-05-20  0:08 Andrew Dyer
2006-05-18 16:59 Doyle, Patrick
2006-05-18 13:40 Doyle, Patrick
2006-05-18 13:54 ` Andrew Lunn
2006-05-18 15:00 ` David Vrabel
2006-05-18 15:14   ` Andrew Lunn
2006-05-18 15:59     ` David Vrabel
2006-05-18 13:18 Doyle, Patrick
2006-05-18 13:26 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F7F756E5ED50F345959AE893AD2F15660A222C@dtcsrvr09.dtccom.com \
    --to=patrick_doyle@dtccom.com \
    --cc=ecos-devel@ecos.sourceware.org \
    --cc=ecos-patches@ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).