public inbox for ecos-devel@sourceware.org
 help / color / mirror / Atom feed
From: "Martin Laabs" <martin.laabs@mailbox.tu-dresden.de>
To: "ecos-devel@ecos.sourceware.org" <ecos-devel@ecos.sourceware.org>
Subject: Re: Patch for CYGPKG_IO_SERIAL_ARM_LPC2XXX
Date: Sun, 23 Nov 2008 14:52:00 -0000	[thread overview]
Message-ID: <op.uk2t7jep724k7f@localhost> (raw)
In-Reply-To: <20081123135238.GB2813@lunn.ch>

Hi Andrew,

> I extended the patch a little. I added a ChangeLog entry and some CDL
> as i suggested to ensure the priorities are different between the
> serial ports.

Thank you.

> However if some other device is using the same priority
> this will not be detected. The correct place to fix that is in the
> HAL. Humm, interesting. If you have asserts enabled, which you should
> when developing, the function hal_interrupt_set_level() has:
>
>
>         CYG_ASSERT((reg_val == 0) || (reg_val == (vector | 0x20)),
>                    "Priority already used by another vector");

Yes - this was my starting point. I wonder that nobody else had this
error since eCos crashed with the two serial ports enabled. (And
IMHO the LPC2XXX serial driver is quite old.)


Greetings,
 Martin


      reply	other threads:[~2008-11-23 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-22 16:06 Martin Laabs
2008-11-22 19:12 ` Andrew Lunn
2008-11-23 22:20   ` Bart Veer
2008-11-23 13:53 ` Andrew Lunn
2008-11-23 14:52   ` Martin Laabs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.uk2t7jep724k7f@localhost \
    --to=martin.laabs@mailbox.tu-dresden.de \
    --cc=ecos-devel@ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).