From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4085 invoked by alias); 1 Sep 2007 12:05:20 -0000 Received: (qmail 4077 invoked by uid 22791); 1 Sep 2007 12:05:19 -0000 X-Spam-Check-By: sourceware.org Received: from rwcrmhc11.comcast.net (HELO rwcrmhc11.comcast.net) (204.127.192.81) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 01 Sep 2007 12:05:09 +0000 Received: from rickmce (c-68-55-175-129.hsd1.md.comcast.net[68.55.175.129]) by comcast.net (rwcrmhc11) with SMTP id <20070901120507m11002uk5ae>; Sat, 1 Sep 2007 12:05:08 +0000 From: "Rick Davis" To: "'Andrew Lunn'" , "'John Mills'" Cc: "'eCos Users'" References: <004701c7e990$9e57b8e0$db072aa0$@net> <20070901103839.GA18291@lunn.ch> In-Reply-To: <20070901103839.GA18291@lunn.ch> Date: Sat, 01 Sep 2007 12:05:00 -0000 Message-ID: <00a901c7ec90$55eed630$01cc8290$@net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: RE: [ECOS] network problem X-SW-Source: 2007-09/txt/msg00005.txt.bz2 Andrew, The issue I reported yesterday about bsd_accept was an issue on my old snapshot. The latest version of bsd_accept is good to go. I am using an older eCos snapshot because of the modifications I had to make for my processors/platforms being used that aren't supported by eCos and my lack of free time to merge all of these changes in to the latest snapshot. I am currently going to be using the latest eCos for the MPC85xx processor. A&M has a port for their Python board (MPC8541) but it hasn't been applied? As for the zpool, a couple/few years ago there was a thread regarding the lack of locking and they added a mutex that was used to prevent pre-emption inside of zalloci and zfreei. Rick -----Original Message----- From: Andrew Lunn [mailto:andrew@lunn.ch] Sent: Saturday, September 01, 2007 6:39 AM To: John Mills Cc: eCos Users; Rick Davis Subject: Re: [ECOS] network problem Hi Folks I've lost track of the different threads about memory leaks in the network stack. It seems like one of the leaks being talked about here was fixed a long time ago: 2003-07-28 Jay Foster * src/sys/kern/sockio.c: Fixed memory leak in accept() call. Do we still need locking in socreate()? socreate calls soalloc. That has a comment /* XXX race condition for reentrant kernel */. The actual problem is in zalloci which does not perform locking on the linked list of elements in the pool. We are re-entrant? socreate() is only called from bsd_socket(). bsd_socket() should only be called from socket(). socket() performs locking, depending on what synchronisation protocol is in use. bsd_tcpip has no synchronisation protocol, so two simultaneous calls to socket() could result in a race! Could somebody please submit a full patch for socreate. Are there any other issues left? Thanks Andrew -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss