From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7897 invoked by alias); 10 Dec 2003 14:56:23 -0000 Mailing-List: contact ecos-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@sources.redhat.com Received: (qmail 7889 invoked from network); 10 Dec 2003 14:56:22 -0000 Received: from unknown (HELO hermes.chez-thomas.org) (63.225.98.241) by sources.redhat.com with SMTP; 10 Dec 2003 14:56:22 -0000 Received: by hermes.chez-thomas.org (Postfix, from userid 2000) id 9B59D50E1BB; Wed, 10 Dec 2003 07:56:21 -0700 (MST) Received: from localhost (localhost.localdomain [127.0.0.1]) by hermes.chez-thomas.org (Postfix) with ESMTP id BDE5050D8F4; Wed, 10 Dec 2003 07:56:19 -0700 (MST) From: Gary Thomas To: Savin Zlobec Cc: ecos-discuss@sources.redhat.com In-Reply-To: <3FD7321E.5010103@elatec.si> References: <3FD7321E.5010103@elatec.si> Content-Type: multipart/mixed; boundary="=-f4BgdLqVJDtFqV1wNyzs" Organization: MLB Associates Message-Id: <1071068178.16658.234.camel@hermes> Mime-Version: 1.0 Date: Wed, 10 Dec 2003 14:56:00 -0000 X-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REFERENCES,REPLY_WITH_QUOTES,UPPERCASE_25_50, USER_AGENT_XIMIAN autolearn=ham version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) Subject: Re: [ECOS] Default boot scripts in RedBoot X-SW-Source: 2003-12/txt/msg00123.txt.bz2 --=-f4BgdLqVJDtFqV1wNyzs Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 992 On Wed, 2003-12-10 at 07:47, Savin Zlobec wrote: > Hello, > > I am using RedBoot configured with default boot script and it doesn't > work just like I expect it to. It looks to me that default boot script > timeout > (CYGNUM_REDBOOT_BOOT_SCRIPT_DEFAULT_TIMEOUT) is used > only when CYGSEM_REDBOOT_FLASH_CONFIG is not set. I use > flash config support in my configuration and when boot script is not set, > than the default boot script is used, but the timeout remains 0 which > aborts the script. > > Also from the cdl option description one could expect that the default > value of > boot_script_timeout would be CYGNUM_REDBOOT_BOOT_SCRIPT_DEFAULT_TIMEOUT, > but it is 0. > > Is this a feature or a bug ? Perhaps the default timeout should always be set. In any case, if you have 'fconfig' enabled, then the value stored in your config database should be what gets used. Try this patch and see if it behaves more like you'd like. -- Gary Thomas MLB Associates --=-f4BgdLqVJDtFqV1wNyzs Content-Disposition: attachment; filename=diffs Content-Type: text/x-patch; name=diffs; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 1283 Index: redboot/current/src/main.c =================================================================== RCS file: /misc/cvsfiles/ecos/packages/redboot/current/src/main.c,v retrieving revision 1.50 diff -u -5 -p -r1.50 main.c --- redboot/current/src/main.c 24 Nov 2003 21:12:07 -0000 1.50 +++ redboot/current/src/main.c 10 Dec 2003 14:53:55 -0000 @@ -297,10 +297,14 @@ cyg_start(void) #ifdef CYGOPT_REDBOOT_FIS_ZLIB_COMMON_BUFFER fis_zlib_common_buffer = workspace_end -= CYGNUM_REDBOOT_FIS_ZLIB_COMMON_BUFFER_SIZE; #endif +#ifdef CYGFUN_REDBOOT_BOOT_SCRIPT + script_timeout = CYGNUM_REDBOOT_BOOT_SCRIPT_DEFAULT_TIMEOUT; +#endif + for (init_entry = __RedBoot_INIT_TAB__; init_entry != &__RedBoot_INIT_TAB_END__; init_entry++) { (*init_entry->fun)(); } mem_segments[0].start = workspace_start; @@ -318,13 +322,10 @@ cyg_start(void) #ifdef CYGFUN_REDBOOT_BOOT_SCRIPT # ifdef CYGDAT_REDBOOT_DEFAULT_BOOT_SCRIPT if (!script) { script = CYGDAT_REDBOOT_DEFAULT_BOOT_SCRIPT; -# ifndef CYGSEM_REDBOOT_FLASH_CONFIG - script_timeout = CYGNUM_REDBOOT_BOOT_SCRIPT_DEFAULT_TIMEOUT; -# endif } # endif if (script) { // Give the guy a chance to abort any boot script unsigned char *hold_script = script; --=-f4BgdLqVJDtFqV1wNyzs Content-Type: text/plain; charset=us-ascii Content-length: 146 -- Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos and search the list archive: http://sources.redhat.com/ml/ecos-discuss --=-f4BgdLqVJDtFqV1wNyzs--