From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4226 invoked by alias); 15 Jun 2005 14:45:39 -0000 Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Received: (qmail 4202 invoked by uid 22791); 15 Jun 2005 14:45:35 -0000 Received: from sta-206-168-96-204.rockynet.com (HELO hermes.chez-thomas.org) (206.168.96.204) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 15 Jun 2005 14:45:35 +0000 Received: by hermes.chez-thomas.org (Postfix, from userid 2000) id 1B15210005A; Wed, 15 Jun 2005 08:45:32 -0600 (MDT) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by hermes.chez-thomas.org (Postfix) with ESMTP id 4B79F100044; Wed, 15 Jun 2005 08:45:30 -0600 (MDT) From: Gary Thomas To: Leandro Fanzone Cc: eCos Discussion In-Reply-To: <42B03AFD.8040106@hasar.com> References: <42B03AFD.8040106@hasar.com> Content-Type: text/plain Date: Wed, 15 Jun 2005 14:45:00 -0000 Message-Id: <1118846730.13965.122.camel@hermes> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [ECOS] HAL_*_STRING X-SW-Source: 2005-06/txt/msg00107.txt.bz2 On Wed, 2005-06-15 at 11:28 -0300, Leandro Fanzone wrote: > Hello, > I'm using ecos 2.0 under x86, and tried to use the HAL_*_STRING > macros, both for reading and writing. They don't work properly; the > assembly output shows that they lack the rep instruction preceding the > insb/outsb instructions. So the macros would be: > > #define HAL_READ_UINT8_STRING( _register_, _buf_, _count_) \ > CYG_MACRO_START \ > asm volatile ( "rep insb" \ > : \ > : "c" (_count_), "d"(_register_), "D"(_buf_) \ > ); \ > CYG_MACRO_END > > #define HAL_WRITE_UINT8_STRING( _register_, _buf_, _count_) \ > CYG_MACRO_START \ > asm volatile ( "rep outsb" \ > : \ > : "c" (_count_), "d"(_register_), "S"(_buf_) \ > ); \ > CYG_MACRO_END > > The same thing for the 16 bit and 32 bit versions. > Regards, These macros are only defined as a matter of reference (and then only by a few HALs since they are not used by the kernel). In any case, it makes sense to correct them. Could you send a proper patch for this to ecos-patches@sourceware.org, please? Include the changes for all versions (8/16/32). Thanks -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss