From: Will Lentz <will_lentz@trimble.com>
To: "Hans Hübner" <hans@huebner.org>
Cc: ecos <ecos-discuss@ecos.sourceware.org>
Subject: Re: [ECOS] uipc_socket.c (and cyg_tcp_maxidle)
Date: Thu, 16 Jun 2005 23:45:00 -0000 [thread overview]
Message-ID: <1118965523.18774.24.camel@localhost.localdomain> (raw)
In-Reply-To: <20050616183534.N69813@web.m68k.de>
Hi Hans,
No problem :-). I'm forwarding this on to the list so others know it
helps.
BTW - any comments from people? In uipc_socket.c soalloc() the
zalloci() is assigned to "so", so it looks right to do the zfreei() on
"so".
Can my patch be applied to CVS?
Thanks,
Will
On Thu, 2005-06-16 at 18:40 +0200, Hans Hübner wrote:
> Hi Will,
>
> thanks for the patch, really! I only started with eCos 2 weeks ago and I
> stumbled across this very problem soon, as the default number of sockets is so
> low and the bug seems to be triggered by socket shortage. With the patch
> applied, my application seems to run much more stable and also the TCP
> counters now look plausible. You really made my day, thanks!
>
> -Hans
>
> On Thu, 16 Jun 2005, Will Lentz wrote:
>
> > The patch does help me when I run out of sockets via the socket() call,
> > but I'm wondering if the zfreei() in sodealloc() is getting the correct
> > second argument. I'll dig into this deeper...
> >
> > Cheers,
> > Will
> >
> > On Thu, 2005-06-16 at 17:46 +0200, Hans Hübner wrote:
> >> On Thu, 16 Jun 2005, Will Lentz wrote:
> >>
> >>> zfreei() is a function, and doesn't directly modify its first argument.
> >>> But - it passes "so" as its second argument, and it modifies the value
> >>> of so->so_zone through that. Looking at zfreei:
> >>
> >> Oops, it helps being awake while posting! Thanks for the patch, I'll apply it
> >> to my source tree immediately :)
> >>
> >> Cheers,
> >> Hans
> >
> >
> >
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
next prev parent reply other threads:[~2005-06-16 23:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-15 22:39 [ECOS] uipc_socket.c Will Lentz
2005-06-16 7:06 ` [ECOS] uipc_socket.c (and cyg_tcp_maxidle) Hans Hübner
2005-06-16 15:36 ` Will Lentz
2005-06-16 15:51 ` Hans Hübner
2005-06-16 16:06 ` Will Lentz
[not found] ` <20050616183534.N69813@web.m68k.de>
2005-06-16 23:45 ` Will Lentz [this message]
2005-06-17 7:15 ` Andrew Lunn
2005-06-17 20:12 ` Andrew Lunn
2005-06-17 21:00 ` Will Lentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118965523.18774.24.camel@localhost.localdomain \
--to=will_lentz@trimble.com \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=hans@huebner.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).