public inbox for ecos-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Daniel Zebralla <daniel.zebralla@zebralla-it.de>
To: ecos-discuss@ecos.sourceware.org
Subject: [ECOS] Re: Typo in assert error message causing confusion?
Date: Wed, 02 Oct 2013 11:26:00 -0000	[thread overview]
Message-ID: <1380713171328-245957.post@n7.nabble.com> (raw)
In-Reply-To: <B1E5ED67-1FE7-43FF-B3A3-E37D58D8A3E8@linear.com>

I get your point of view. However, I assume that someone would like to know
what's broken instead of what would be the case if the message would have
not been displayed. If my system stops with a kernel panic and tells me
"Pointer is valid" I would be like -> oO.

As I can see inside eCos source, I'm not the only one understanding those
assertion messages this way, some examples:
CYG_ASSERT( freeret , "Couldn't free!" );
CYG_ASSERT( interr == 0, "internal lock failed!" );
CYG_ASSERT( usertmp->next != NULL, "Couldn't find message queue user" );
CYG_ASSERT( stacksize >= PTHREAD_STACK_MIN, "Inadequate stack size
supplied");
CYG_ASSERT( ticks != 0, "Zero tick count");

To sum it up:
- Some eCos developers use assertion messages to say what failed
- Some eCos developers use assertion messages to say what would have passed
This inconsistency confuses people like me, new to eCos and debugging
something which I don't fully understand yet.

Any further comments/opinions?
- Daniel



--
View this message in context: http://sourceware-org.1504.n7.nabble.com/Typo-in-assert-error-message-causing-confusion-tp245807p245957.html
Sent from the Sourceware - ecos-discuss mailing list archive at Nabble.com.

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

  reply	other threads:[~2013-10-02 11:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01  9:01 [ECOS] " Daniel Zebralla
2013-10-01 15:27 ` Michael Jones
2013-10-02 11:26   ` Daniel Zebralla [this message]
2013-10-02 12:00     ` [ECOS] " Stanislav Meduna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380713171328-245957.post@n7.nabble.com \
    --to=daniel.zebralla@zebralla-it.de \
    --cc=ecos-discuss@ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).