[ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER

[ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER

[Dave Airlie]

Hi,
	I've just gotten the snapshot from the 8th Sept, and cannot get
the serial stuff to compile with CYGINT_IO_SERIAL_BLOCK_TRANSFER enabled..

in serial.c it keeps getting problems in the differing SERIAL_CALLBACKS...

Has anyone else had problems like this .. I'm running an ARM-PID board

Dave.

-- 
      David Airlie, Software Engineer, Parthus Technologies plc.,
       Mary Rosse Centre, National Tech Park, Limerick, Ireland.
   t: +353-61-508116 / f: +353-61-508101 / David.Airlie@parthus.com

Re: [ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER

[Jesper Skov]

>>>>> "Dave" == Dave Airlie <airlied@parthus.com> writes:

Dave> Hi, I've just gotten the snapshot from the 8th Sept, and cannot
Dave> get the serial stuff to compile with
Dave> CYGINT_IO_SERIAL_BLOCK_TRANSFER enabled..

Dave> in serial.c it keeps getting problems in the differing
Dave> SERIAL_CALLBACKS...

Dave> Has anyone else had problems like this .. I'm running an ARM-PID
Dave> board

That is an interface, not a user-modifyable option. If the _driver_
does not implement block transfers (which the PID driver does not),
the interface will not be activated.

The callback compile errors are due to the IO driver expecting the
callbacks functions to be defined by the device driver - and they
are not.

Jesper

Re: [ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER

[Dave Airlie]

But I have another driver that does implement the interfaces, and I need
to run it and the PID serial ports,

Can I not do this?

Dave.

On 13 Sep 2000, Jesper Skov wrote:

> >>>>> "Dave" == Dave Airlie <airlied@parthus.com> writes:
> 
> Dave> Hi, I've just gotten the snapshot from the 8th Sept, and cannot
> Dave> get the serial stuff to compile with
> Dave> CYGINT_IO_SERIAL_BLOCK_TRANSFER enabled..
> 
> Dave> in serial.c it keeps getting problems in the differing
> Dave> SERIAL_CALLBACKS...
> 
> Dave> Has anyone else had problems like this .. I'm running an ARM-PID
> Dave> board
> 
> That is an interface, not a user-modifyable option. If the _driver_
> does not implement block transfers (which the PID driver does not),
> the interface will not be activated.
> 
> The callback compile errors are due to the IO driver expecting the
> callbacks functions to be defined by the device driver - and they
> are not.
> 
> Jesper
> 

-- 
      David Airlie, Software Engineer, Parthus Technologies plc.,
       Mary Rosse Centre, National Tech Park, Limerick, Ireland.
   t: +353-61-508116 / f: +353-61-508101 / David.Airlie@parthus.com

Re: [ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER

[Jesper Skov]

>>>>> "Dave" == Dave Airlie <airlied@parthus.com> writes:

Dave> But I have another driver that does implement the interfaces,
Dave> and I need to run it and the PID serial ports,

Dave> Can I not do this?

Yes, but you need to provide more information. Can we see the compiler
error, please.

Jesper

Re: [ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER

[Dave Airlie]

Here are the compiler errors...

Dave.

arm-elf-gcc -c  -I/home/airlied/devel/ecos-000908/pid-tree/install/include
-I/home/airlied/devel/ecos-000908/ecos/packages/io/serial/current
-I/home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src
-I/home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/tests
-I. -I/home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
-mcpu=arm7tdmi -Wall -Wpointer-arith -Wstrict-prototypes -Winline -Wundef
-Woverloaded-virtual -g -O2 -ffunction-sections -fdata-sections -fno-rtti
-fno-exceptions -fvtable-gc -finit-priority -Wp,-MD,src/common/serial.tmp
-o src/common/io_serial_serial.o
/home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
serial.c
/home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
serial.c:89: warning: initialization
from incompatible pointer type
/home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
serial.c:89: parse
error before `serial_indicate_status'
/home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
serial.c:1029: warning: `serial_data_xmt_done'
defined but not used
make[1]: *** [src/common/serial.o.d] Error 1


On Wed, 13 Sep 2000, Jesper Skov wrote:

> >>>>> "Dave" == Dave Airlie <airlied@parthus.com> writes:
> 
> Dave> But I have another driver that does implement the interfaces,
> Dave> and I need to run it and the PID serial ports,
> 
> Dave> Can I not do this?
> 
> Yes, but you need to provide more information. Can we see the compiler
> error, please.
> 
> Jesper
> 

-- 
      David Airlie, Software Engineer, Parthus Technologies plc.,
       Mary Rosse Centre, National Tech Park, Limerick, Ireland.
   t: +353-61-508116 / f: +353-61-508101 / David.Airlie@parthus.com

Re: [ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER

[Jesper Skov]

>>>>> "Dave" == Dave Airlie <airlied@parthus.com> writes:

Dave> Here are the compiler errors...

Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
Dave> serial.c
Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
Dave> serial.c:89: warning: initialization from incompatible pointer
Dave> type
Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
Dave> serial.c:89: parse error before `serial_indicate_status'
Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
Dave> serial.c:1029: warning: `serial_data_xmt_done' defined but not
Dave> used make[1]: *** [src/common/serial.o.d] Error 1

That should have told you what was wrong. Didn't you look at the code? :)

Try the below.

Jesper

Index: ChangeLog
===================================================================
RCS file: /local/cvsfiles/ecc/ecc/io/serial/current/ChangeLog,v
retrieving revision 1.206
diff -u -5 -r1.206 ChangeLog
--- ChangeLog	2000/09/06 07:53:47	1.206
+++ ChangeLog	2000/09/13 13:33:14
@@ -1,5 +1,9 @@
+2000-09-13  Jesper Skov  <jskov@redhat.com>
+
+	* include/serial.h (SERIAL_CALLBACKS): Fix typo.
+
 2000-09-06  Jesper Skov  <jskov@redhat.com>
 
 	* tests/ser_test_protocol.inl: Renamed some option names due to SH
 	serial driver reorg.
 
Index: include/serial.h
===================================================================
RCS file: /local/cvsfiles/ecc/ecc/io/serial/current/include/serial.h,v
retrieving revision 1.13
diff -u -5 -r1.13 serial.h
--- include/serial.h	2000/08/01 08:59:13	1.13
+++ include/serial.h	2000/09/13 13:33:07
@@ -93,11 +93,11 @@
     _xmt_char,                                          \
     _rcv_char,                                          \
     _data_rcv_req,                                      \
     _data_rcv_done,                                     \
     _data_xmt_req,                                      \
-    _data_xmt_done                                      \
+    _data_xmt_done,                                     \
     _indicate_status                                    \
 };
 # else
 #  define SERIAL_CALLBACKS(_l,_init,_xmt_char,_rcv_char, _data_rcv_req, _data_rcv_done, _data_xmt_req, _data_xmt_done)  \
 serial_callbacks_t _l = {                               \

Re: [ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER

[Dave Airlie]

Doh... should have spotted that one .. was running on no breakfast brain
wasn't switched on :-)

Thanks,
Dave.

On Wed, 13 Sep 2000, Jesper Skov wrote:

> >>>>> "Dave" == Dave Airlie <airlied@parthus.com> writes:
> 
> Dave> Here are the compiler errors...
> 
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:89: warning: initialization from incompatible pointer
> Dave> type
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:89: parse error before `serial_indicate_status'
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:1029: warning: `serial_data_xmt_done' defined but not
> Dave> used make[1]: *** [src/common/serial.o.d] Error 1
> 
> That should have told you what was wrong. Didn't you look at the code? :)
> 
> Try the below.
> 
> Jesper
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /local/cvsfiles/ecc/ecc/io/serial/current/ChangeLog,v
> retrieving revision 1.206
> diff -u -5 -r1.206 ChangeLog
> --- ChangeLog	2000/09/06 07:53:47	1.206
> +++ ChangeLog	2000/09/13 13:33:14
> @@ -1,5 +1,9 @@
> +2000-09-13  Jesper Skov  <jskov@redhat.com>
> +
> +	* include/serial.h (SERIAL_CALLBACKS): Fix typo.
> +
>  2000-09-06  Jesper Skov  <jskov@redhat.com>
>  
>  	* tests/ser_test_protocol.inl: Renamed some option names due to SH
>  	serial driver reorg.
>  
> Index: include/serial.h
> ===================================================================
> RCS file: /local/cvsfiles/ecc/ecc/io/serial/current/include/serial.h,v
> retrieving revision 1.13
> diff -u -5 -r1.13 serial.h
> --- include/serial.h	2000/08/01 08:59:13	1.13
> +++ include/serial.h	2000/09/13 13:33:07
> @@ -93,11 +93,11 @@
>      _xmt_char,                                          \
>      _rcv_char,                                          \
>      _data_rcv_req,                                      \
>      _data_rcv_done,                                     \
>      _data_xmt_req,                                      \
> -    _data_xmt_done                                      \
> +    _data_xmt_done,                                     \
>      _indicate_status                                    \
>  };
>  # else
>  #  define SERIAL_CALLBACKS(_l,_init,_xmt_char,_rcv_char, _data_rcv_req, _data_rcv_done, _data_xmt_req, _data_xmt_done)  \
>  serial_callbacks_t _l = {                               \
> 

-- 
      David Airlie, Software Engineer, Parthus Technologies plc.,
       Mary Rosse Centre, National Tech Park, Limerick, Ireland.
   t: +353-61-508116 / f: +353-61-508101 / David.Airlie@parthus.com