[ECOS] Q: how to select PHY for Ethernet driver?

[ECOS] Q: how to select PHY for Ethernet driver?

[Grant Edwards]

Hi,

I've got an Ethernet driver than will currently use either of
two types of PHY (determined by linking either of two object
files with the driver).  I'll soon need to add support for a
third.  Currently the PHY selection is hard-wired (it can't be
changed using ecosconfig).

I'd like to be able to select the PHY using ecosconfig, and it
appears I could do it two ways:

  1) Have the PHY selection be a configuration parameter in
     the CDL description of my driver that changes the list of
	 files to be linked.

  2) Have the PHY support implemented in separate packages that
	 can be enabled/disabled (only one could be enabled at a
	 time).

Is there any conventional wisdom that would lead one to pick
one approach over the other?

-- 
Grant Edwards
grante@visi.com

Re: [ECOS] Q: how to select PHY for Ethernet driver?

[Jonathan Larmour]

Grant Edwards wrote:
> 
> Hi,
> 
> I've got an Ethernet driver than will currently use either of
> two types of PHY (determined by linking either of two object
> files with the driver).  I'll soon need to add support for a
> third.  Currently the PHY selection is hard-wired (it can't be
> changed using ecosconfig).
> 
> I'd like to be able to select the PHY using ecosconfig, and it
> appears I could do it two ways:
> 
>   1) Have the PHY selection be a configuration parameter in
>      the CDL description of my driver that changes the list of
>          files to be linked.
> 
>   2) Have the PHY support implemented in separate packages that
>          can be enabled/disabled (only one could be enabled at a
>          time).
> 
> Is there any conventional wisdom that would lead one to pick
> one approach over the other?

If these are actually different board hardware configurations then the
second would seem sensible. But if there is a lot of code sharing (i.e. the
types of PHY are actually pretty similar in all but detail that can be
abstracted out) then 1) is probably the way to go.

Jifl
-- 
Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS  Tel: +44 (1223) 728762
"Plan to be spontaneous tomorrow."  ||  These opinions are all my own fault