From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Edwards To: Jonathan Larmour Cc: ecos-discuss@sources.redhat.com, Gary Thomas Subject: Re: [ECOS] MS_TICKS() revisited Date: Fri, 09 Feb 2001 12:12:00 -0000 Message-id: <20010209141632.B4898@visi.com> References: <20010209131835.A4738@visi.com> <3A8449EC.9545FBB6@redhat.com> <20010209140122.A4898@visi.com> <3A844D11.4C910A3D@redhat.com> X-SW-Source: 2001-02/msg00160.html On Fri, Feb 09, 2001 at 08:03:29PM +0000, Jonathan Larmour wrote: > Grant Edwards wrote: > > > Thanks for the patch. One query before I apply it: > > > > > > +#if !defined(CYGPKG_REDBOOT_NETWORKING) > > > +#define MS_TICKS_DELAY() hal_delay_us(1000) > > > +#endif > > > + > > > > > > Any reason this isn't do_ms_tick() ? > > > > IIRC, I was thinking at the time that do_ms_tick() was part of > > the networking package. It isn't, so it probably should be > > do_ms_tick(). Now that I think of it, it might be a better > > idea to move the definitions for MS_TICKS() and > > MS_TICKS_DELAY() from net.h into a more general spot like > > redboot.h. Then we don't need that chunk at all. > > I think that would be fine. If Gary T also agrees (CC'd) could you resubmit > your patch with that change? Uh, wait, that piece of pre-processor code is in a file (net_io.c) that is part of the networking package, so we can ditch it without moving the definitions out of net.h. I've no idea why I thought that needed to be there. :/ -- Grant Edwards grante@visi.com