From: Grant Edwards <grante@visi.com>
To: ecos-discuss@sources.redhat.com
Subject: [ECOS] Re: RedBoot: load.c srecord input offset fix
Date: Thu, 19 Apr 2001 13:37:00 -0000 [thread overview]
Message-ID: <20010419153901.A29584@visi.com> (raw)
In-Reply-To: <20010419152550.A29254@visi.com>
On Thu, Apr 19, 2001 at 03:25:50PM -0500, Grant Edwards wrote:
> > The "offset" variable in load_srec_image() isn't incremented
> > properly (assuming its purpose is to keep track of the current
> > byte offset in the input stream). My version of load.c has
> > diverged enough that I can't generate a usable patch, so I'll
> > summarize the changes:
Oops, the "discard rest of line" loop at the bottom of the main
while loop also needs to be fixed:
default:
printf("Invalid S-record at offset 0x%lx, type: %x\n",
(unsigned long)offset, type);
return;
}
- while ((c = (*getc)()) != '\n') offset++;
+ do {
+ c = (*getc)();
+ ++offset;
+ } while (c != '\n');
}
}
--
Grant Edwards
grante@visi.com
next prev parent reply other threads:[~2001-04-19 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-19 13:19 [ECOS] " Grant Edwards
2001-04-19 13:24 ` [ECOS] " Grant Edwards
2001-04-19 13:37 ` Grant Edwards [this message]
2001-04-20 0:11 ` [ECOS] " Jonathan Larmour
2001-04-20 5:40 ` Gary Thomas
2001-04-20 7:31 ` Grant Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010419153901.A29584@visi.com \
--to=grante@visi.com \
--cc=ecos-discuss@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).