From: Andrew Lunn <andrew@lunn.ch>
To: Eric de Jong <list_ericdejong_10@gmx.net>
Cc: eCos discussion <ecos-discuss@sources.redhat.com>
Subject: Re: [ECOS] Problem with THUMB mode with AT91
Date: Tue, 23 Sep 2003 11:50:00 -0000 [thread overview]
Message-ID: <20030923115040.GD25606@lunn.ch> (raw)
In-Reply-To: <000201c3819e$723d9440$e33922c7@ericnt>
On Tue, Sep 23, 2003 at 08:46:07AM +0200, Eric de Jong wrote:
> The LED macro is not suited for use in thumb mode. I cannot say when this bug
> was introduced, as I did use thumb mode without debugging once. The simplest way
> is to comment out the LED calls in vector.S where thumb mode is used (line 427,
> 457, 462)
> Another way is to modify the LED macro, eg change
> mov r1,#0x0000FF00
> to
> mov r1,#0xFF
> lsl r1, #8
>
> and in .macro _led y (for my custom EB40A platform)
> mov r1,#(\y<<16)
> to
> mov r1,#(\y)
> lsl r1,#16
Could you make a proper patch out of this, with a ChangeLog entry.
Thanks
Andrew
--
Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
and search the list archive: http://sources.redhat.com/ml/ecos-discuss
prev parent reply other threads:[~2003-09-23 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-22 12:52 Claudio Leonel
2003-09-23 6:45 ` Eric de Jong
2003-09-23 11:50 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030923115040.GD25606@lunn.ch \
--to=andrew@lunn.ch \
--cc=ecos-discuss@sources.redhat.com \
--cc=list_ericdejong_10@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).