From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30340 invoked by alias); 18 Jun 2004 11:58:55 -0000 Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Received: (qmail 30313 invoked from network); 18 Jun 2004 11:58:54 -0000 Received: from unknown (HELO londo.lunn.ch) (80.238.139.98) by sourceware.org with SMTP; 18 Jun 2004 11:58:54 -0000 Received: from lunn by londo.lunn.ch with local (Exim 3.36 #1 (Debian)) id 1BbI19-0002mz-00; Fri, 18 Jun 2004 13:58:47 +0200 Date: Fri, 18 Jun 2004 11:58:00 -0000 To: ?yvind Harboe Cc: Andrew Lunn , ecos-discuss@sources.redhat.com Message-ID: <20040618115847.GA2031@lunn.ch> Mail-Followup-To: ?yvind Harboe , Andrew Lunn , ecos-discuss@sources.redhat.com References: <1087469710.31564.11.camel@famine> <20040617121021.GB20791@lunn.ch> <1087482637.31564.28.camel@famine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1087482637.31564.28.camel@famine> User-Agent: Mutt/1.5.6+20040523i From: Andrew Lunn Subject: Re: [ECOS] New memory allocation debug feature X-SW-Source: 2004-06/txt/msg00177.txt.bz2 > > You also need to provide an implementation in libtarget.a for when the > > application does not have such a function. eg all the test programs > > will not provide this function, so will fail to link when your new > > option is enabled. So please add a week function which does nothing, > > or maybe throws an CYG_FAIL(). > > Hmmm... Can this be done without adding a new source file? Can you declare a function using C calling convention in a C++ file? I don't know, im a C programmer. If you can, i suggest you add it to the end of malloc.cxx > > > It would also be nice if you used to same coding style for the patch > > as for the rest of the file, ie { on the same line as the if etc. > > Should be OK now. The patch looks like the indentation is wrong, but that could be that tabs are being shown wrongly. Once we have a patch with a the we[ea]k function i will take a closer look. > My dream is that CVS would automatically enforce all such formatting > rules transparently, and that text editors would present the source code > in the preferred coloring and formatting of the programmer. :-) CVS enforcing it only causes me more problems since i would have to reject more patches. You should try emacs. It does colouring i like and once you have told it what formatting style to use it also does most of the layout work as well. Andrew -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss