[ECOS] fix for pci.c

[ECOS] fix for pci.c

[Michael Varga]

First:
I wrote a fix for the io/src/pci.c,pci.h.

This code fails to map base address registers when
a gap existes in consecutive addresses. For instance,
when a device has a valid base0 invalid base1 and a
valid base2. I can submit it if anyone is interested.




Second:
I modified the redboot package and created my version
v1_1 based on the current. I then did

>./ecosadmin.tcl add redboot-v1.1.epk

then i did,

>ecosconfig version v1_1 CYGPKG_REDBOOT
C CYGPKG_REDBOOT_XSCALE_OPTIONS,"requires"
    constraint not satisfied: CYGPKG_REDBOOT_ARM_LINUX_EXEC_ADDRESS_DEFAULT
!= 0
C CYGPKG_REDBOOT_XSCALE_OPTIONS,"requires"
    constraint not satisfied: CYGPKG_REDBOOT_ARM_LINUX_EXEC_ADDRESS_DEFAULT
!= 0


I scanned the mail-lists and found that these errors where sometimes solved
when users upgraded to ecosconfig-2.0. I upgraded, but It did not work for
me.


I suspect there is something wrong with my new redboot package.
Does anyone know what I might look for?

thanks


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] fix for pci.c

[Andrew Lunn]

On Mon, Aug 30, 2004 at 10:40:55AM -0700, Michael Varga wrote:
> First:
> I wrote a fix for the io/src/pci.c,pci.h.
> 
> This code fails to map base address registers when
> a gap existes in consecutive addresses. For instance,
> when a device has a valid base0 invalid base1 and a
> valid base2. I can submit it if anyone is interested.

I think somebody already did submit such a patch. 

[Goes and looks at the ChangeLog.] 

Yep, 2003-09-29 & 2003-11-18. Are you using old sources?

> Second:
> I modified the redboot package and created my version
> v1_1 based on the current. I then did
> 
> >./ecosadmin.tcl add redboot-v1.1.epk
> 
> then i did,
> 
> >ecosconfig version v1_1 CYGPKG_REDBOOT
> C CYGPKG_REDBOOT_XSCALE_OPTIONS,"requires"
>     constraint not satisfied: CYGPKG_REDBOOT_ARM_LINUX_EXEC_ADDRESS_DEFAULT
> != 0
> C CYGPKG_REDBOOT_XSCALE_OPTIONS,"requires"
>     constraint not satisfied: CYGPKG_REDBOOT_ARM_LINUX_EXEC_ADDRESS_DEFAULT
> != 0

CYGPKG_REDBOOT_ARM_LINUX_EXEC_ADDRESS_DEFAULT is normally set by the
hal/arm/xscale/*/current/misc/redboot_*.ecm file. You probably need to
import it again, but will first need to modify current to v1_1 for the
redboot package.

        Andrew

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] fix for pci.c

[Michael Varga]

I am new to ecos, so could you be more explicit
in your suggested fix.

As you suggested, I modifed "redboot_ROM.ecm" and changed current
to v1_1. But now I get an additional error, I suspect I missed something
else
that is required:

can not load version 'v1_1' of 'CYGPKG_REDBOOT' version 'current' is already
loaded



Below are the commands I use to coinfigure ecos.


/usr/bin/ecosconfig new grg redboot
/usr/bin/ecosconfig import
${ECOS_REPOSITORY}/hal/arm/xscale/grg/current/misc/redboot_ROM.ecm
/usr/bin/ecosconfig add intel_npe
/usr/bin/ecosconfig add CYGPKG_DEVS_CAVIUM_ARM_GRG_NITROX
/usr/bin/ecosconfig add CYGPKG_IO_CAVIUM
/usr/bin/ecosconfig add grg_npe
/usr/bin/ecosconfig version v1_1 CYGPKG_IO_PCI
/usr/bin/ecosconfig version v1_1 CYGPKG_REDBOOT
/usr/bin/ecosconfig tree


thanks
Mike V.




----- Original Message -----
From: "Andrew Lunn" <andrew@lunn.ch>
To: "Michael Varga" <mike.varga@cavium.com>
Cc: <ecos-discuss@sources.redhat.com>
Sent: Monday, August 30, 2004 10:59 AM
Subject: Re: [ECOS] fix for pci.c


> On Mon, Aug 30, 2004 at 10:40:55AM -0700, Michael Varga wrote:
> > First:
> > I wrote a fix for the io/src/pci.c,pci.h.
> >
> > This code fails to map base address registers when
> > a gap existes in consecutive addresses. For instance,
> > when a device has a valid base0 invalid base1 and a
> > valid base2. I can submit it if anyone is interested.
>
> I think somebody already did submit such a patch.
>
> [Goes and looks at the ChangeLog.]
>
> Yep, 2003-09-29 & 2003-11-18. Are you using old sources?
>
> > Second:
> > I modified the redboot package and created my version
> > v1_1 based on the current. I then did
> >
> > >./ecosadmin.tcl add redboot-v1.1.epk
> >
> > then i did,
> >
> > >ecosconfig version v1_1 CYGPKG_REDBOOT
> > C CYGPKG_REDBOOT_XSCALE_OPTIONS,"requires"
> >     constraint not satisfied:
CYGPKG_REDBOOT_ARM_LINUX_EXEC_ADDRESS_DEFAULT
> > != 0
> > C CYGPKG_REDBOOT_XSCALE_OPTIONS,"requires"
> >     constraint not satisfied:
CYGPKG_REDBOOT_ARM_LINUX_EXEC_ADDRESS_DEFAULT
> > != 0
>
> CYGPKG_REDBOOT_ARM_LINUX_EXEC_ADDRESS_DEFAULT is normally set by the
> hal/arm/xscale/*/current/misc/redboot_*.ecm file. You probably need to
> import it again, but will first need to modify current to v1_1 for the
> redboot package.
>
>         Andrew


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] fix for pci.c

[Andrew Lunn]

On Mon, Aug 30, 2004 at 11:32:23AM -0700, Michael Varga wrote:
> 
> I am new to ecos, so could you be more explicit
> in your suggested fix.
> 
> As you suggested, I modifed "redboot_ROM.ecm" and changed current
> to v1_1. But now I get an additional error, I suspect I missed something
> else
> that is required:
> 
> can not load version 'v1_1' of 'CYGPKG_REDBOOT' version 'current' is already
> loaded
> 
> 
> 
> Below are the commands I use to coinfigure ecos.
> 
> 
> /usr/bin/ecosconfig new grg redboot
> /usr/bin/ecosconfig import
> ${ECOS_REPOSITORY}/hal/arm/xscale/grg/current/misc/redboot_ROM.ecm
> /usr/bin/ecosconfig add intel_npe
> /usr/bin/ecosconfig add CYGPKG_DEVS_CAVIUM_ARM_GRG_NITROX
> /usr/bin/ecosconfig add CYGPKG_IO_CAVIUM
> /usr/bin/ecosconfig add grg_npe
> /usr/bin/ecosconfig version v1_1 CYGPKG_IO_PCI
> /usr/bin/ecosconfig version v1_1 CYGPKG_REDBOOT

If you have already changed the version to v1_1 in the ecm file there
is no need to do this here.

You might need to 

ecosconfig remove redboot

before you import the .ecm file.

        Andrew

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss