Re: [ECOS] tftp server stack problems

[Andrew Lunn <andrew@lunn.ch>]

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

On Thu, May 25, 2006 at 11:58:22AM +0200, J?rgen Lambrecht wrote:
> Hello,
> 
> I use the freeBSD networking stack, but the default stack size for the 
> tftp server is wrong:
> 
>         cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE {
>             display "Stack size for TFTP threads."
>             flavor  data
>             default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))
> 
> When I use the configtool, or idem with ecosconfig with scripts, 
> CYGNUM_HAL_STACK_SIZE_TYPICAL is always 0!

It looks like this has been broken since 2004-06-17. 
CYGNUM_HAL_STACK_SIZE_TYPICAL is not a CDL variable, it is a #define
in the architecture HAL.

Please could you test this patch.

       Thanks
          Andrew

[-- Attachment #2: tftpd.diff --]
[-- Type: text/plain, Size: 1553 bytes --]

Index: net/common/current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/common/current/ChangeLog,v
retrieving revision 1.76
diff -u -r1.76 ChangeLog
--- net/common/current/ChangeLog	26 Mar 2006 11:15:06 -0000	1.76
+++ net/common/current/ChangeLog	25 May 2006 10:35:13 -0000
@@ -1,3 +1,10 @@
+2006-05-25  Andrew Lunn  <andrew.lunn@ascom.ch>
+
+	* cdl/net.cdl: Fix calculation of TFTPD stack
+	size. CYGNUM_HAL_STACK_SIZE_TYPICAL is not a CDL variable, it is a
+	#define, so we need to ensure that the compiler evaluates the
+	expression, not the CDL library.
+  
 2006-03-26  Andrew Lunn  <andrew.lunn@ascom.ch>
 
 	* tests/nc_test_framework.h: 
Index: net/common/current/cdl/net.cdl
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/common/current/cdl/net.cdl,v
retrieving revision 1.15
diff -u -r1.15 net.cdl
--- net/common/current/cdl/net.cdl	2 Aug 2004 10:43:39 -0000	1.15
+++ net/common/current/cdl/net.cdl	25 May 2006 10:35:14 -0000
@@ -170,7 +170,7 @@
         cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE {
             display "Stack size for TFTP threads."
             flavor  data
-            default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))
+            default_value { "(CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))" }
             description   "
                This option controls the size of the stack used for the 
                TFTP server. The default should be sufficient for most cases


[-- Attachment #3: Type: text/plain, Size: 148 bytes --]

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss