From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7839 invoked by alias); 31 May 2007 23:17:22 -0000 Received: (qmail 7830 invoked by uid 22791); 31 May 2007 23:17:21 -0000 X-Spam-Check-By: sourceware.org Received: from londo.lunn.ch (HELO londo.lunn.ch) (80.238.139.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 31 May 2007 23:17:19 +0000 Received: from lunn by londo.lunn.ch with local (Exim 3.36 #1 (Debian)) id 1HtttF-0002OA-00; Fri, 01 Jun 2007 01:17:09 +0200 Date: Thu, 31 May 2007 23:32:00 -0000 To: Jim Seymour Cc: ecos-discuss@ecos.sourceware.org Message-ID: <20070531231709.GC5944@lunn.ch> Mail-Followup-To: Jim Seymour , ecos-discuss@ecos.sourceware.org References: <465F4A25.8070407@cipher.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <465F4A25.8070407@cipher.com> User-Agent: Mutt/1.5.13 (2006-08-11) From: Andrew Lunn X-IsSubscribed: yes Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: Re: [ECOS] AT91 Serial Receive: asserts when buffer fills up X-SW-Source: 2007-05/txt/msg00225.txt.bz2 On Thu, May 31, 2007 at 03:20:21PM -0700, Jim Seymour wrote: > In the serial DSR in at91_serial.c, there is a CYG_FAIL() macro if the > receive buffer fills up. (Line #612) > > Is this appropriate? We like to run with asserts turned on (at least > during development), but in our application, overflowing the receive > buffer is not that big of a deal. > > It appears that all the other serial drivers quietly throw away > characters if their receive buffer is full. Any complaints if I submit > a patch to do the same in the AT91 driver? "all other" equates to just the sh/scif driver. At the moment there are only two drivers to do block transfers, the AT91 being the other. Removing the CYG_FAIL is O.K. Andrew -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss