From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27061 invoked by alias); 22 Aug 2007 10:52:19 -0000 Received: (qmail 26963 invoked by uid 22791); 22 Aug 2007 10:52:19 -0000 X-Spam-Check-By: sourceware.org Received: from quina.moeckel.org (HELO quina.moeckel.org) (217.160.223.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Aug 2007 10:52:16 +0000 Received: from bluebird.headcrashers.bnfh (bluebird.headcrashers.org [IPv6:2001:8d8:81:a11:204:acff:fe97:190]) (authenticated bits=0) by quina.moeckel.org (8.13.8/8.13.8/Debian-3) with ESMTP id l7MAq9h1005525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 22 Aug 2007 12:52:10 +0200 Received: from executor.headcrashers.bnfh (IDENT:root@executor.headcrashers.bnfh [IPv6:2001:8d8:81:a11:209:6bff:fee0:8244]) by bluebird.headcrashers.bnfh (8.13.8/8.13.8) with ESMTP id l7MAq8JL023890; Wed, 22 Aug 2007 12:52:08 +0200 Received: from executor.headcrashers.bnfh (IDENT:woodstoc@localhost [127.0.0.1]) by executor.headcrashers.bnfh (8.13.8/8.13.8) with ESMTP id l7MApWR2002798; Wed, 22 Aug 2007 12:51:32 +0200 (CEST) Received: (from woodstoc@localhost) by executor.headcrashers.bnfh (8.13.8/8.13.8/Submit) id l7MApWqu002637; Wed, 22 Aug 2007 12:51:32 +0200 (CEST) Date: Wed, 22 Aug 2007 10:52:00 -0000 From: Hans Rosenfeld To: Andrew Lunn Cc: ecos-discuss@ecos.sourceware.org Message-ID: <20070822105132.GF2126@grumpf.hope-2000.org> References: <21907044.603801184047861289.JavaMail.servlet@kundenserver> <20070817140209.GA26081@grumpf.hope-2000.org> <20070817171322.GB26081@grumpf.hope-2000.org> <20070820151336.GA1125@grumpf.hope-2000.org> <20070822082451.GF31057@lunn.ch> <20070822084026.GA2126@grumpf.hope-2000.org> <20070822091803.GH31057@lunn.ch> <20070822095228.GD2126@grumpf.hope-2000.org> <20070822100626.GJ31057@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070822100626.GJ31057@lunn.ch> User-Agent: Mutt/1.4.2.2i X-IsSubscribed: yes Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: Re: [ECOS] Re: LPC2xxx patch for support of vectored interrupt controller X-SW-Source: 2007-08/txt/msg00110.txt.bz2 On Wed, Aug 22, 2007 at 12:06:26PM +0200, Andrew Lunn wrote: > I wanted to avoid _0 and _1 because it may make reader of the code > think they have the value of 0 and 1! If a reading is interested in > the value, using A and B makes the reader go looking for the actual > value, rather than assume they are 0 and 1. Yes, that was bad style on my part. > In the code i would replace 0 with CYGNUM_KERNEL_INTR_TEST_PRIO_A and > 1 with CYGNUM_KERNEL_INTR_TEST_PRIO_B, since the defaults set them to > these values. Maybe we should have CYGNUM_KERNEL_INTR_TEST_PRIO_C, too. The tests create three interrupts. -- %SYSTEM-F-ANARCHISM, The operating system has been overthrown -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss