From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8853 invoked by alias); 22 Aug 2007 11:12:28 -0000 Received: (qmail 8781 invoked by uid 22791); 22 Aug 2007 11:12:27 -0000 X-Spam-Check-By: sourceware.org Received: from londo.lunn.ch (HELO londo.lunn.ch) (80.238.139.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Aug 2007 11:12:23 +0000 Received: from lunn by londo.lunn.ch with local (Exim 3.36 #1 (Debian)) id 1INo8G-0002pw-00; Wed, 22 Aug 2007 13:12:16 +0200 Date: Wed, 22 Aug 2007 11:12:00 -0000 From: Andrew Lunn To: Hans Rosenfeld Cc: Andrew Lunn , ecos-discuss@ecos.sourceware.org Message-ID: <20070822111216.GL31057@lunn.ch> Mail-Followup-To: Hans Rosenfeld , Andrew Lunn , ecos-discuss@ecos.sourceware.org References: <21907044.603801184047861289.JavaMail.servlet@kundenserver> <20070817140209.GA26081@grumpf.hope-2000.org> <20070817171322.GB26081@grumpf.hope-2000.org> <20070820151336.GA1125@grumpf.hope-2000.org> <20070822082451.GF31057@lunn.ch> <20070822084026.GA2126@grumpf.hope-2000.org> <20070822091803.GH31057@lunn.ch> <20070822095228.GD2126@grumpf.hope-2000.org> <20070822100626.GJ31057@lunn.ch> <20070822105132.GF2126@grumpf.hope-2000.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070822105132.GF2126@grumpf.hope-2000.org> User-Agent: Mutt/1.5.16 (2007-06-11) X-IsSubscribed: yes Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: Re: [ECOS] Re: LPC2xxx patch for support of vectored interrupt controller X-SW-Source: 2007-08/txt/msg00112.txt.bz2 On Wed, Aug 22, 2007 at 12:51:32PM +0200, Hans Rosenfeld wrote: > On Wed, Aug 22, 2007 at 12:06:26PM +0200, Andrew Lunn wrote: > > I wanted to avoid _0 and _1 because it may make reader of the code > > think they have the value of 0 and 1! If a reading is interested in > > the value, using A and B makes the reader go looking for the actual > > value, rather than assume they are 0 and 1. > > Yes, that was bad style on my part. > > > In the code i would replace 0 with CYGNUM_KERNEL_INTR_TEST_PRIO_A and > > 1 with CYGNUM_KERNEL_INTR_TEST_PRIO_B, since the defaults set them to > > these values. > > Maybe we should have CYGNUM_KERNEL_INTR_TEST_PRIO_C, too. The tests > create three interrupts. O.K. Could your produce a patch which contains all these changes and a ChangeLog entry in both the Kernel package and the HAL. Thanks Andrew -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss