From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24175 invoked by alias); 11 Dec 2007 13:51:52 -0000 Received: (qmail 24167 invoked by uid 22791); 11 Dec 2007 13:51:52 -0000 X-Spam-Check-By: sourceware.org Received: from londo.lunn.ch (HELO londo.lunn.ch) (80.238.139.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Dec 2007 13:51:46 +0000 Received: from lunn by londo.lunn.ch with local (Exim 3.36 #1 (Debian)) id 1J25WL-0006fD-00; Tue, 11 Dec 2007 14:51:37 +0100 Date: Tue, 11 Dec 2007 13:51:00 -0000 From: Andrew Lunn To: ?yvind Harboe Cc: Andrew Lunn , eCos Disuss Message-ID: <20071211135137.GG30586@lunn.ch> Mail-Followup-To: ?yvind Harboe , Andrew Lunn , eCos Disuss References: <20071211094252.GD30586@lunn.ch> <20071211100356.GF30586@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: [ECOS] Re: Check for illegal address range in io/flash X-SW-Source: 2007-12/txt/msg00030.txt.bz2 On Tue, Dec 11, 2007 at 11:09:40AM +0100, ?yvind Harboe wrote: > On Dec 11, 2007 11:03 AM, Andrew Lunn wrote: > > > > > I mainly want the busted check in flash_erase() to be removed. > > > ASSERT's are probably fine. > > What is actually wrong with this check? I think it is trying to deal with flash which are placed at the very top of memory. The last valid byte is 0xffffffff. However is you try to erase 0xffff0000 with length 0x10000, which is valid, end_addr becomes 0x0 and things probably go wrong. This code i think it trying to spot this and set end_addr to 0xffffffff. I don't want to remove this until i fully understand what is causing your problem and how this code is wrong. Please could you explain what you are seeing. Thanks Andrew -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss