public inbox for ecos-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Steven Clugston <steven.clugston@newcastle.ac.uk>
Cc: ecos-discuss@ecos.sourceware.org
Subject: Re: [ECOS] MPC555 serial receive drops bytes
Date: Tue, 06 May 2008 17:55:00 -0000	[thread overview]
Message-ID: <20080506175421.GC22242@lunn.ch> (raw)
In-Reply-To: <96F77944E1BA554D814FBC549EC5D3F00B48603F@moonraker.campus.ncl.ac.uk>

> With the exception fixed, I was still getting overruns so I moved the
> code out of the DSR code into the ISR to improve latency. Since its only
> moving a byte out of a register, I thought it doesn't really need a DSR.

You have to be very careful here. You cannot call the 

(chan->callbacks->rcv_char)(chan, (cyg_uint8)scdr);

from ISR context. It has to be in DSR context. It will play around
with threads, unblocking readers etc, which can only be done safely in
DSR context.

    Andrew


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

  reply	other threads:[~2008-05-06 17:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06 15:59 Steven Clugston
2008-05-06 17:55 ` Andrew Lunn [this message]
2008-05-07  8:41   ` Steven Clugston
2008-05-07  8:57     ` Andrew Lunn
2008-05-07 16:32 ` [ECOS] " Alex Upchurch
2008-05-08  9:49   ` Steven Clugston
2008-05-08 20:16     ` [ECOS] " Alex Upchurch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080506175421.GC22242@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ecos-discuss@ecos.sourceware.org \
    --cc=steven.clugston@newcastle.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).