public inbox for ecos-discuss@sourceware.org
 help / color / mirror / Atom feed
* [ECOS] vrc4373_serial.c
@ 2000-07-21 15:00 Chris Morrow
  2000-07-21 15:51 ` Chris Morrow
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Morrow @ 2000-07-21 15:00 UTC (permalink / raw)
  To: ecos-discuss

In the function vrc4373_serial_init() in 
.../devs/serial/mips/vrc4373/current/src/vrc4373_serial.c
should the third argument to the cyg_drv_interrupt_create() call
be vrc4373_chan->base instead of VRC4373_SCC_BASE+SCC_CHANNEL_A?

I guess this board only has one serial port, so this wouldn't
matter that much.

-- 
Chris Morrow	YottaYotta Inc.
email:		cmorrow@yottayotta.com
phone:		(780) 439 9000 ext 227
web:		http://www.yottayotta.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ECOS] vrc4373_serial.c
  2000-07-21 15:00 [ECOS] vrc4373_serial.c Chris Morrow
@ 2000-07-21 15:51 ` Chris Morrow
  2000-07-21 16:07   ` Jonathan Larmour
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Morrow @ 2000-07-21 15:51 UTC (permalink / raw)
  To: ecos-discuss

Ah, the comment at the start of ns16550_serial_DSR() explains it.
You have to check channel A for both sets of interrupts.

Having a similar comment in vrc4373_serial_init() would be useful.

Chris Morrow wrote:
> 
> In the function vrc4373_serial_init() in
> .../devs/serial/mips/vrc4373/current/src/vrc4373_serial.c
> should the third argument to the cyg_drv_interrupt_create() call
> be vrc4373_chan->base instead of VRC4373_SCC_BASE+SCC_CHANNEL_A?
> 
> I guess this board only has one serial port, so this wouldn't
> matter that much.
> 
> --
> Chris Morrow    YottaYotta Inc.
> email:          cmorrow@yottayotta.com
> phone:          (780) 439 9000 ext 227
> web:            http://www.yottayotta.com

-- 
Chris Morrow	YottaYotta Inc.
email:		cmorrow@yottayotta.com
phone:		(780) 439 9000 ext 227
web:		http://www.yottayotta.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ECOS] vrc4373_serial.c
  2000-07-21 15:51 ` Chris Morrow
@ 2000-07-21 16:07   ` Jonathan Larmour
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Larmour @ 2000-07-21 16:07 UTC (permalink / raw)
  To: Chris Morrow; +Cc: ecos-discuss

Chris Morrow wrote:
> 
> Ah, the comment at the start of ns16550_serial_DSR() explains it.

You mean vrc4373_serial_DSR() presumably.

> You have to check channel A for both sets of interrupts.
> 
> Having a similar comment in vrc4373_serial_init() would be useful.

Done.
 
> Chris Morrow wrote:
> >
> > In the function vrc4373_serial_init() in
> > .../devs/serial/mips/vrc4373/current/src/vrc4373_serial.c
> > should the third argument to the cyg_drv_interrupt_create() call
> > be vrc4373_chan->base instead of VRC4373_SCC_BASE+SCC_CHANNEL_A?
> >
> > I guess this board only has one serial port, so this wouldn't
> > matter that much.

And it has two :-).

Jifl
-- 
Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS  Tel: +44 (1223) 728762
"Plan to be spontaneous tomorrow."  ||  These opinions are all my own fault

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2000-07-21 16:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-07-21 15:00 [ECOS] vrc4373_serial.c Chris Morrow
2000-07-21 15:51 ` Chris Morrow
2000-07-21 16:07   ` Jonathan Larmour

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).