From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Larmour To: Chris Morrow Cc: ecos-discuss@sourceware.cygnus.com Subject: Re: [ECOS] vrc4373_serial.c Date: Fri, 21 Jul 2000 16:07:00 -0000 Message-id: <3978D7B2.AD056B1B@redhat.co.uk> References: <3978C80D.36922459@YottaYotta.com> <3978D3F8.BBFA7EEA@YottaYotta.com> X-SW-Source: 2000-07/msg00216.html Chris Morrow wrote: > > Ah, the comment at the start of ns16550_serial_DSR() explains it. You mean vrc4373_serial_DSR() presumably. > You have to check channel A for both sets of interrupts. > > Having a similar comment in vrc4373_serial_init() would be useful. Done. > Chris Morrow wrote: > > > > In the function vrc4373_serial_init() in > > .../devs/serial/mips/vrc4373/current/src/vrc4373_serial.c > > should the third argument to the cyg_drv_interrupt_create() call > > be vrc4373_chan->base instead of VRC4373_SCC_BASE+SCC_CHANNEL_A? > > > > I guess this board only has one serial port, so this wouldn't > > matter that much. And it has two :-). Jifl -- Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS Tel: +44 (1223) 728762 "Plan to be spontaneous tomorrow." || These opinions are all my own fault