Re: [ECOS] mips mmu setup

[Jonathan Larmour <jlarmour@redhat.com>]

Chris Morrow wrote:
> 
> For the vrc4373 port, the hal_mips_setup routine
> use add instructions for the following sequence.
> 
>         li      tmp,PADDR_INC
>         add     vaddr,vaddr,tmp
>         add     paddr0,paddr0,tmp
> 
> Which is okay until you try to map in 2 gig of
> address space at which point the vaddr calculate
> will result in 0x80000000 during the last interation
> of the loop. This will cause an interger overflow
> exception.
> 
> All the add's in that function should probably be addu's.

Thanks for the report. Assuming you have hardware that barfs on this, in
the next anonymous CVS update, can you check that I've got all the ones
that need doing? Also if there are any in the arch HAL please pipe up,
preferably with a patch of course :-).

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine