From: Jonathan Larmour <jlarmour@redhat.com>
To: Ho Shui Choy Stanley PS03B NCS <scho@ncs.com.sg>
Cc: "Ecos-Discuss (E-mail)" <ecos-discuss@sources.redhat.com>
Subject: Re: [ECOS] Serial application
Date: Wed, 09 May 2001 12:27:00 -0000 [thread overview]
Message-ID: <3AF99A32.BEFA069@redhat.com> (raw)
In-Reply-To: <19C34CD863B1D4118E2800508BAF663A0112F62A@STONE>
Ho Shui Choy Stanley PS03B NCS wrote:
>
> Here is what I changed.
>
> in /io/serial/current/src/common/serial.c
>
> serial_read {
> ...
> ...
> #ifdef CYGOPT_IO_SERIAL_SUPPORT_NONBLOCKING
> if (cbuf->blocking) { <- previously checking for false
> *len = size; // characters actually read
> res = -EAGAIN;
> break;
> }
> #endif // CYGOPT_IO_SERIAL_SUPPORT_NONBLOCKING
But the check _should_ be for !cbuf->blocking surely?
Jifl
--
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine
next prev parent reply other threads:[~2001-05-09 12:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-08 17:53 Ho Shui Choy Stanley PS03B NCS
2001-05-09 12:27 ` Jonathan Larmour [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-05-09 17:54 Ho Shui Choy Stanley PS03B NCS
2001-05-09 19:33 ` Jonathan Larmour
2001-05-08 1:43 Ho Shui Choy Stanley PS03B NCS
2001-05-07 23:52 Ho Shui Choy Stanley PS03B NCS
2001-05-08 6:30 ` Jonathan Larmour
2001-05-07 23:04 Ho Shui Choy Stanley PS03B NCS
2001-04-26 18:23 [ECOS] Serial Application Ho Shui Choy Stanley PS03B NCS
2001-04-27 3:12 ` Robert Cragie
2001-04-27 3:30 ` Carlos Camargo
2001-04-27 4:13 ` Robert Cragie
2001-04-25 21:18 Ho Shui Choy Stanley PS03B NCS
2001-04-26 11:14 ` Jonathan Larmour
2001-04-25 3:07 Ho Shui Choy Stanley PS03B NCS
2001-04-25 9:15 ` Jonathan Larmour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AF99A32.BEFA069@redhat.com \
--to=jlarmour@redhat.com \
--cc=ecos-discuss@sources.redhat.com \
--cc=scho@ncs.com.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).