From: Jonathan Larmour <jlarmour@redhat.com>
To: jjtsai <jjtsai@itri.org.tw>
Cc: ecos-discuss@sources.redhat.com
Subject: Re: [ECOS] [eCos] a question about ROMFS
Date: Thu, 19 Jul 2001 23:42:00 -0000 [thread overview]
Message-ID: <3B57D288.E0A7B73A@redhat.com> (raw)
In-Reply-To: <003401c10f58$b2853ea0$8c78608c@ccl.itri.org.tw>
jjtsai wrote:
>
> ----- Original Message -----
> From: Jonathan Larmour <jlarmour@redhat.com>
> To: jjtsai <jjtsai@itri.org.tw>
> Cc: <ecos-discuss@sources.redhat.com>
> Sent: Wednesday, July 18, 2001 4:09 AM
> Subject: Re: [ECOS] [eCos] a question about ROMFS
>
> > jjtsai wrote:
> > > > I'll see if I can work on a better patch.
> > > That would be great!
> >
> > Can you try the attached patch for me please? I haven't even tried
> > compiling it yet nevermind testing it, but I was hoping you could do that
> > instead :-). Let me know how it goes. Then I'll check it in.
> Your attached patch still has problems. Test program (fseek.c) is attached.
>
> I do a little modification on the stream.inl (based on your patch) and
> romfs.c.
> It works well in my test program. Patch files are attached.
>
> Have a try please. I am afraid if I make any mistakes.
>
> Instruction about how to apply the patch files:
>
> cd $(ECOS_REPOSITORY)/packages/language/c/libc/stdio/current/include
> patch -p0 < $(WHERE_THE_PATCH_IS)/stream_inl.pat
> (This is the patch to the original file.)
Oops, I was so caught up in trying to seek within the buffer, I forgot
about the original problem :). I'm going to update anon CVS with this later
today. You can try it from there to make sure it's okay. I made a slight
variation on your change, just for efficiency and code size.
> cd $(ECOS_REPOSITORY)/packages/fs/rom/current/src
> patch -p0 < $(WHERE_THE_PATCH_IS)/romfs_c.pat
I don't get this one. Your change doesn't appear to do anything because
further in dev_fo_lseek there is:
// All OK, set fp offset and return new position.
*apos = fp->f_offset = pos;
And your comment for the SEEK_CUR case: are you saying that pos shouldn't
be changed? If so, can you explain in more detail why?
Jifl
--
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine
Come to the Red Hat TechWorld open source conference in Brussels!
Keynotes, techie talks and exhibitions http://www.redhat-techworld.com/
prev parent reply other threads:[~2001-07-19 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-16 0:47 jjtsai
2001-07-16 14:01 ` Jonathan Larmour
2001-07-17 0:11 ` jjtsai
2001-07-17 13:09 ` Jonathan Larmour
2001-07-18 0:07 ` jjtsai
2001-07-19 23:42 ` Jonathan Larmour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B57D288.E0A7B73A@redhat.com \
--to=jlarmour@redhat.com \
--cc=ecos-discuss@sources.redhat.com \
--cc=jjtsai@itri.org.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).