[ECOS] server_test.c and SO_REUSE*

[ECOS] server_test.c and SO_REUSE*

[Trenton D. Adams]

I found something in server_test.c that I think is wrong.  It doesn't
affect the functionality of the actual test.

The following function calls are in the wrong order.
    if(bind(s, (struct sockaddr *) &local, sizeof(local)) < 0) {
        pexit("bind error");
    }
    if (setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &one, sizeof(one))) {
        pexit("setsockopt SO_REUSEADDR");
    }
    if (setsockopt(s, SOL_SOCKET, SO_REUSEPORT, &one, sizeof(one))) {
        pexit("setsockopt SO_REUSEPORT");
    }

They should be like so
    if (setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &one, sizeof(one))) {
        pexit("setsockopt SO_REUSEADDR");
    }
    if (setsockopt(s, SOL_SOCKET, SO_REUSEPORT, &one, sizeof(one))) {
        pexit("setsockopt SO_REUSEPORT");
    }
    if(bind(s, (struct sockaddr *) &local, sizeof(local)) < 0) {
        pexit("bind error");
    }

If the two socket options aren't set before the bind, they have no
affect, and you cannot reuse the port or address if you want to.

Since the listening socket is never closed, it doesn't affect the actual
test.


Is this correct?  My program wouldn't work without the setsockopt ()
calls before bind.

Trenton D. Adams
Embedded Developer
Windows Developer
Extreme Engineering Ltd.
Calgary Alberta

Phone: 403 640 9494 ext 208
Fax:   403 640 9599

Re: [ECOS] server_test.c and SO_REUSE*

[Jonathan Larmour]

"Trenton D. Adams" wrote:
> 
> I found something in server_test.c that I think is wrong.  It doesn't
> affect the functionality of the actual test.
[snip]
> If the two socket options aren't set before the bind, they have no
> affect, and you cannot reuse the port or address if you want to.
> 
> Since the listening socket is never closed, it doesn't affect the actual
> test.
> 
> Is this correct?  My program wouldn't work without the setsockopt ()
> calls before bind.

Yes, that's right, I'll "fix" the test.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine