From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Larmour To: Chris Morrow Cc: eCos discussion , Jesper Skov Subject: Re: [ECOS] variant rm7000 interrupt masking Date: Wed, 08 Aug 2001 11:29:00 -0000 Message-id: <3B7184FE.A0DC86E9@redhat.com> References: <003601c11eab$673d3530$740aa8c0@richards> <3B6F27EB.5EBEE6D4@redhat.com> <002301c11f48$a03a82a0$740aa8c0@richards> <3B6FF834.4E6C1CC3@redhat.com> <3B701ABD.C9F89469@YottaYotta.com> <3B7097D5.F2BCEA3E@YottaYotta.com> X-SW-Source: 2001-08/msg00252.html Chris Morrow wrote: > > There are a couple more difficulties with the MASK/UNMASK MACROS. > These ones work better. > > #define HAL_INTERRUPT_MASK( _vector_ [snip] These changes look fine, and I'm happy to apply them. I've written a ChangeLog entry for you. > Also, I believe rm7000 variants need a custom hal_intc_decode macro to > deal with the rm7000's interrupt control register. Yes they should. Got a patch? :-). > Is there any reason not to place these macros in > .../packages/hal/mips/rm7000/var/current/include/{variant.inc,var_intr.h} Don't know why not. Jesper? Jifl -- Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062 Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine