From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Larmour To: Wade Jensen Cc: ecos-discuss@sources.redhat.com, Hugo Tyson Subject: Re: [ECOS] Synchronization problem in IP stack Date: Wed, 12 Sep 2001 14:12:00 -0000 Message-id: <3B9FCFD9.2B435F24@redhat.com> References: <07256AC5.00703FDB.00@chd-nt-mail01.inter-tel.com> X-SW-Source: 2001-09/msg00296.html Wade Jensen wrote: > > 1. I noticed that there are many places in the IP stack that use #ifdef __ECOS > or #ifdef __ECOS__, but the __ECOS__ label was not defined in the compiler > options. Because of this, a call to sblock() was using the macro rather than > the function call. True. I think the better fix is to fix the places using __ECOS__ to use __ECOS. I'll make it so. > 2. The sblock() function was incorrectly assuming that sb_lock() unlocked the > scheduler. > > 3. There was an unnecessary assertion in cyg_tsleep(). While I'm tempted to agree with you and just apply these bits of the patch, I'll have to defer to Hugo, who has studied this part of the stack far more than I. Jifl -- Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062 Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine